Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2920)

Unified Diff: base/memory/generic_shared_memory_id.cc

Issue 1280513002: Add GenericSharedMemoryId and use w/ GpuMemoryBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@trackpools
Patch Set: Comments and tweaks. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/memory/generic_shared_memory_id.cc
diff --git a/base/memory/generic_shared_memory_id.cc b/base/memory/generic_shared_memory_id.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a941a6763f1f02c3844b2f9d5e2e72f57e5eb7e8
--- /dev/null
+++ b/base/memory/generic_shared_memory_id.cc
@@ -0,0 +1,24 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/memory/generic_shared_memory_id.h"
+
+#include "base/format_macros.h"
+#include "base/strings/stringprintf.h"
+
+namespace base {
+
reveman 2015/08/06 04:25:06 nit: unnecessary blankline
ericrk 2015/08/06 18:28:08 shouldn't have been in memory namespace (that isn'
+namespace memory {
+
+base::trace_event::MemoryAllocatorDumpGuid GetGenericSharedMemoryGUIDForTracing(
+ uint64_t tracing_process_id,
+ GenericSharedMemoryId generic_shared_memory_id) {
+ return base::trace_event::MemoryAllocatorDumpGuid(
+ base::StringPrintf("genericsharedmemory-x-process/%" PRIx64 "/%d",
+ tracing_process_id, generic_shared_memory_id));
+}
+
+} // namespace memory
+
reveman 2015/08/06 04:25:06 nit: unnecessary blankline
ericrk 2015/08/06 18:28:08 Acknowledged.
+} // namespace base

Powered by Google App Engine
This is Rietveld 408576698