Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: base/memory/generic_shared_memory_id.cc

Issue 1280513002: Add GenericSharedMemoryId and use w/ GpuMemoryBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@trackpools
Patch Set: Comments and tweaks. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/memory/generic_shared_memory_id.h"
6
7 #include "base/format_macros.h"
8 #include "base/strings/stringprintf.h"
9
10 namespace base {
11
reveman 2015/08/06 04:25:06 nit: unnecessary blankline
ericrk 2015/08/06 18:28:08 shouldn't have been in memory namespace (that isn'
12 namespace memory {
13
14 base::trace_event::MemoryAllocatorDumpGuid GetGenericSharedMemoryGUIDForTracing(
15 uint64_t tracing_process_id,
16 GenericSharedMemoryId generic_shared_memory_id) {
17 return base::trace_event::MemoryAllocatorDumpGuid(
18 base::StringPrintf("genericsharedmemory-x-process/%" PRIx64 "/%d",
19 tracing_process_id, generic_shared_memory_id));
20 }
21
22 } // namespace memory
23
reveman 2015/08/06 04:25:06 nit: unnecessary blankline
ericrk 2015/08/06 18:28:08 Acknowledged.
24 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698