Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1280263002: Make ApplyBlockElementCommand not to modify uneditable element (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent, yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make ApplyBlockElementCommand not to modify uneditable element The issue 515249 is caused by calling |lastPositionInNode()| with null pointer which is result of |SplitTextCommand| with uneditable text node. This patch avoid this situation by making |ApplyBlockElementCommand| not to modify uneditable element in |rangeForParagraphSplittingTextNodesIfNeeded()| member function where we split text node. BUG=515249 TEST=LayoutTests/editing/execCommand/format-block-uneditable-crash.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200238

Patch Set 1 : 2015-08-10T14:45:18 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
A LayoutTests/editing/execCommand/format-block-uneditable-crash.html View 1 chunk +19 lines, -0 lines 0 comments Download
M Source/core/editing/ApplyBlockElementCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-10 06:11:01 UTC) #2
yoichio
lgtm
5 years, 4 months ago (2015-08-10 07:37:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280263002/1
5 years, 4 months ago (2015-08-10 07:59:30 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 08:02:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200238

Powered by Google App Engine
This is Rietveld 408576698