gpu: workaround force_cube_map_positive_x_allocation fixes Android crash.

gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc

Index: gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc
diff --git a/gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc b/gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..625876933106e450248e0531fe8880b183be2c3b
--- /dev/null
+++ b/gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc
@@ -0,0 +1,108 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <GLES2/gl2.h>
+
+#include "gpu/command_buffer/tests/gl_manager.h"
+#include "gpu/command_buffer/tests/gl_test_utils.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace gpu {
+
+namespace {
+const GLenum kCubeMapTextureTargets[] = {
+    GL_TEXTURE_CUBE_MAP_POSITIVE_X, GL_TEXTURE_CUBE_MAP_NEGATIVE_X,
+    GL_TEXTURE_CUBE_MAP_POSITIVE_Y, GL_TEXTURE_CUBE_MAP_NEGATIVE_Y,
+    GL_TEXTURE_CUBE_MAP_POSITIVE_Z, GL_TEXTURE_CUBE_MAP_NEGATIVE_Z,
+};
+}  // namespace
+
+// A collection of tests that exercise the cube map texture.
+class GLCubeMapTextureTest : public testing::TestWithParam<GLenum> {
+ protected:
+  void SetUp() override {
+    gl_.Initialize(GLManager::Options());
+    for (int i = 0; i < 256; i++) {
+      pixels_[i * 4] = 255u;
+      pixels_[(i * 4) + 1] = 0;
+      pixels_[(i * 4) + 2] = 0;
+      pixels_[(i * 4) + 3] = 255u;
+    }
+  }
+
+  void TearDown() override { gl_.Destroy(); }
+
+  uint8 pixels_[256 * 4];
+  const int width_ = 16;
+  GLManager gl_;
+};
+
+INSTANTIATE_TEST_CASE_P(GLCubeMapTextureTests,
+                        GLCubeMapTextureTest,
+                        ::testing::ValuesIn(kCubeMapTextureTargets));
+
+TEST_P(GLCubeMapTextureTest, TexImage2DAfterFBOBinding) {
+  GLenum cube_map_target = GetParam();
+
+  GLuint texture = 0;
+  glGenTextures(1, &texture);
+
+  glBindTexture(GL_TEXTURE_CUBE_MAP, texture);
+  EXPECT_TRUE(glGetError() == GL_NO_ERROR);
+
+  GLuint framebuffer_id = 0;
+  glGenFramebuffers(1, &framebuffer_id);
+  glBindFramebuffer(GL_FRAMEBUFFER, framebuffer_id);
+  glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, cube_map_target,
+                         texture, 0);
+  EXPECT_TRUE(glGetError() == GL_NO_ERROR);
+
+  // force_gl_finish_after_compositing workaround prevents Nexus 5 crash.
+  // TODO(dshwang): remove the workaround when it's fixed. crbug.com/518889
+  glTexImage2D(cube_map_target, 0, GL_RGBA, width_, width_, 0, GL_RGBA,
+               GL_UNSIGNED_BYTE, pixels_);
+  EXPECT_TRUE(glGetError() == GL_NO_ERROR);
+}
+
+#if defined(OS_WIN)
+// ANGLE crashes. crbug.com/518889
+TEST_P(GLCubeMapTextureTest, DISABLED_ReadPixels) {
+#elif defined(OS_LINUX) || defined(OS_MACOSX)
+// NVIDIA reports GL_INVALID_FRAMEBUFFER_OPERATION : glReadPixels: framebuffer
+// incomplete. crbug.com/518889

[Ken Russell (switch to Gerrit), 2015/08/11 18:17:49]

I think this test is wrong. Section 4.4.4 "Framebuffer Completeness" of the ES
3.0.4 spec says that if the color attachment is a cube map texture and the
texture isn't cube map complete, then the framebuffer is incomplete. You're only
attaching a single attachment, so the FBO is incomplete.

[dshwang, 2015/08/11 19:15:43]

Aha, thank you for enlightening me. you are right. Nvidia might check cube
complete. The test is wrong. I changed the test use complete FBO

In addition, Android crash is still problem, so I'll remain the workaround.

APPENDIX. (https://www.khronos.org/registry/gles/specs/3.0/es_spec_3.0.4.pdf)
3.8.13 Texture Completeness
Additionally, a cube map texture is
cube complete if the following conditions all hold true:
• The levelbase arrays of each of the six texture images making up the cube
map have identical, positive, and square dimensions.
• The levelbase arrays were each specified with the same effective internal
format

4.4.4 Framebuffer Completeness
Framebuffer Attachment Completeness
if FRAMEBUFFER_ATTACHMENT_OBJECT_NAME
names a cubemap texture, the texture must also be cube complete.

+TEST_P(GLCubeMapTextureTest, DISABLED_ReadPixels) {
+#else
+TEST_P(GLCubeMapTextureTest, ReadPixels) {
+#endif
+  GLenum cube_map_target = GetParam();
+
+  GLuint texture = 0;
+  glGenTextures(1, &texture);
+
+  glBindTexture(GL_TEXTURE_CUBE_MAP, texture);
+  EXPECT_TRUE(glGetError() == GL_NO_ERROR);
+
+  glTexImage2D(cube_map_target, 0, GL_RGBA, width_, width_, 0, GL_RGBA,
+               GL_UNSIGNED_BYTE, pixels_);
+  EXPECT_TRUE(glGetError() == GL_NO_ERROR);
+
+  GLuint framebuffer_id = 0;
+  glGenFramebuffers(1, &framebuffer_id);
+  glBindFramebuffer(GL_FRAMEBUFFER, framebuffer_id);
+  glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, cube_map_target,
+                         texture, 0);
+  // force_gl_finish_after_compositing workaround prevents Nexus 5 crash.
+  // TODO(dshwang): remove the workaround when it's fixed. crbug.com/518889
+  EXPECT_TRUE(glGetError() == GL_NO_ERROR);
+
+  // Check that FB is complete.
+  EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_COMPLETE),
+            glCheckFramebufferStatus(GL_FRAMEBUFFER));

[dshwang, 2015/08/11 19:15:43]

by the way, NVIDIA should fail here, not glRealPixel inside
GLTestHelper::CheckPixels().

+
+  // ANGLE crashes on glReadPixels() except for CUBE_MAP_POSITIVE_X.
+  GLTestHelper::CheckPixels(0, 0, width_, width_, 0, pixels_);
+  EXPECT_TRUE(GL_NO_ERROR == glGetError());
+}
+
+}  // namespace gpu