tools/gn/docs/cookbook.md - Issue 1280123005: tools/gn: Remove includes of basictypes.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/docs/cookbook.md

Issue 1280123005: tools/gn: Remove includes of basictypes.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/docs/cookbook.md

diff --git a/tools/gn/docs/cookbook.md b/tools/gn/docs/cookbook.md

index 02845fcea63e19304b037537de017449716d4ae1..63516452f153afca71805b1c6e78936c9eb26530 100644

--- a/tools/gn/docs/cookbook.md

+++ b/tools/gn/docs/cookbook.md

@@ -317,7 +317,7 @@ Notes:

GN is much more strict about header file checking. You may encounter

errors that your target doesn't depend on the target containing a

certain header file. The most common example is including

-`base/basictypes.h` without having `//base` in your project's dependency

+`base/macros.h` without having `//base` in your project's dependency

list. The solution is to just add the missing dependency.

The dependency tree must be a DAG. Some components might share headers