Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: tools/gn/args.h

Issue 1280123005: tools/gn: Remove includes of basictypes.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/action_values.h ('k') | tools/gn/build_settings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/args.h
diff --git a/tools/gn/args.h b/tools/gn/args.h
index 345516cb8148f034474dc2f8138bc77701277220..1f9cb52f7ded8f52c5be389b594e0abfbff307e4 100644
--- a/tools/gn/args.h
+++ b/tools/gn/args.h
@@ -5,12 +5,13 @@
#ifndef TOOLS_GN_ARGS_H_
#define TOOLS_GN_ARGS_H_
-#include "base/basictypes.h"
#include "base/containers/hash_tables.h"
+#include "base/macros.h"
#include "base/synchronization/lock.h"
-#include "tools/gn/err.h"
#include "tools/gn/scope.h"
+class Err;
+
extern const char kBuildArgs_Help[];
// Manages build arguments. It stores the global arguments specified on the
@@ -101,7 +102,7 @@ class Args {
// toolchain may define variables in different locations.
mutable DeclaredArgumentsPerToolchain declared_arguments_per_toolchain_;
- Args& operator=(const Args& other); // Disallow assignment.
brettw 2015/08/09 17:15:18 Ah yeah, I used to copy this around, but all that
+ DISALLOW_ASSIGN(Args);
};
#endif // TOOLS_GN_ARGS_H_
« no previous file with comments | « tools/gn/action_values.h ('k') | tools/gn/build_settings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698