Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1280123005: tools/gn: Remove includes of basictypes.h. (Closed)

Created:
5 years, 4 months ago by tfarina
Modified:
5 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, Dirk Pranke, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/gn: Remove includes of basictypes.h. We can just use the standard integer types from stdint.h now that our toolchain supports it and include macros.h for DISALLOW macros. BUG=138542 TEST=gn and gn_unittests builds R=brettw@chromium.org Committed: https://crrev.com/f51a763e89037495adc060afff129afeaeb2f0f3 Cr-Commit-Position: refs/heads/master@{#342570}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -51 lines) Patch
M tools/gn/action_values.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/args.h View 2 chunks +4 lines, -3 lines 1 comment Download
M tools/gn/build_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/builder.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/builder_record.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/c_include_iterator.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/command_refs.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/config_values.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/config_values_generator.h View 1 chunk +1 line, -4 lines 0 comments Download
M tools/gn/deps_iterator.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/docs/cookbook.md View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/docs/reference.md View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/header_checker.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/inherited_libraries.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/input_file.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/input_file_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/ninja_target_writer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/ninja_target_writer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/ninja_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/parse_tree.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/path_output.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/scheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/scope.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/scope_per_file_provider.h View 1 chunk +1 line, -2 lines 0 comments Download
M tools/gn/setup.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/substitution_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/target.h View 1 chunk +1 line, -3 lines 0 comments Download
M tools/gn/template.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/test_with_scope.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/tokenizer.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/tool.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/trace.h View 1 chunk +1 line, -2 lines 0 comments Download
M tools/gn/value.h View 4 chunks +6 lines, -6 lines 0 comments Download
M tools/gn/value.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/visibility.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
tfarina
5 years, 4 months ago (2015-08-08 16:36:20 UTC) #1
brettw
neato, LGTM https://codereview.chromium.org/1280123005/diff/1/tools/gn/args.h File tools/gn/args.h (left): https://codereview.chromium.org/1280123005/diff/1/tools/gn/args.h#oldcode104 tools/gn/args.h:104: Args& operator=(const Args& other); // Disallow assignment. ...
5 years, 4 months ago (2015-08-09 17:15:18 UTC) #2
brettw
neato, LGTM https://codereview.chromium.org/1280123005/diff/1/tools/gn/args.h File tools/gn/args.h (left): https://codereview.chromium.org/1280123005/diff/1/tools/gn/args.h#oldcode104 tools/gn/args.h:104: Args& operator=(const Args& other); // Disallow assignment. ...
5 years, 4 months ago (2015-08-09 17:15:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280123005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280123005/1
5 years, 4 months ago (2015-08-10 00:42:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-10 00:55:47 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 00:56:20 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f51a763e89037495adc060afff129afeaeb2f0f3
Cr-Commit-Position: refs/heads/master@{#342570}

Powered by Google App Engine
This is Rietveld 408576698