Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1280043003: Sandbox html_viewer on Linux. (Closed)

Created:
5 years, 4 months ago by Elliot Glaysher
Modified:
5 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, penghuang+watch-mandoline_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Sandbox html_viewer on Linux." This fixes a midair collision with a file move. This creates a font_service which does the same role as font_config_ipc_linux.cc does in content/. This lets us sandbox the html_viewer, while still being able to communicate with fontconfig. Also prewarms the ICU timezone data, along with doing all the prewarming that's done in the core_services sandbox. BUG=492524 NOPRESUBMIT=true First Review URL: https://codereview.chromium.org/1274743004 Committed: https://crrev.com/7eb0efde374571b5c76417c7df061fee4cd7acd8 Cr-Commit-Position: refs/heads/master@{#342409}

Patch Set 1 #

Patch Set 2 : Switch to new location of MessagePumpMojo. #

Patch Set 3 : Update DEPS for the new dependency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+821 lines, -8 lines) Patch
A components/font_service/BUILD.gn View 1 chunk +36 lines, -0 lines 0 comments Download
A + components/font_service/DEPS View 1 2 1 chunk +3 lines, -1 line 0 comments Download
A components/font_service/font_service_app.h View 1 chunk +53 lines, -0 lines 0 comments Download
A components/font_service/font_service_app.cc View 1 chunk +123 lines, -0 lines 0 comments Download
A + components/font_service/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/font_service/public/cpp/BUILD.gn View 1 2 chunks +8 lines, -2 lines 0 comments Download
A components/font_service/public/cpp/font_loader.h View 1 chunk +67 lines, -0 lines 0 comments Download
A components/font_service/public/cpp/font_loader.cc View 1 chunk +63 lines, -0 lines 0 comments Download
A components/font_service/public/cpp/font_service_thread.h View 1 chunk +97 lines, -0 lines 0 comments Download
A components/font_service/public/cpp/font_service_thread.cc View 1 1 chunk +158 lines, -0 lines 0 comments Download
A components/font_service/public/cpp/mapped_font_file.h View 1 chunk +54 lines, -0 lines 0 comments Download
A components/font_service/public/cpp/mapped_font_file.cc View 1 chunk +48 lines, -0 lines 0 comments Download
A + components/font_service/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A components/font_service/public/interfaces/font_service.mojom View 1 chunk +38 lines, -0 lines 0 comments Download
M components/html_viewer/BUILD.gn View 2 chunks +8 lines, -0 lines 0 comments Download
M components/html_viewer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/html_viewer/global_state.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M components/html_viewer/html_viewer_main.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M mandoline/app/core_services_initialization.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mandoline/services/core_services/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M mandoline/services/core_services/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M mojo/runner/child_process.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/runner/linux_sandbox.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/application_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Elliot Glaysher
Rubber stampable. The only differences are in Patch Set 2.
5 years, 4 months ago (2015-08-07 17:36:07 UTC) #2
jam
lgtm
5 years, 4 months ago (2015-08-07 19:22:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280043003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280043003/40001
5 years, 4 months ago (2015-08-07 19:23:19 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-07 19:27:05 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 19:27:31 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7eb0efde374571b5c76417c7df061fee4cd7acd8
Cr-Commit-Position: refs/heads/master@{#342409}

Powered by Google App Engine
This is Rietveld 408576698