Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1274743004: Sandbox html_viewer on Linux. (Closed)

Created:
5 years, 4 months ago by Elliot Glaysher
Modified:
5 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, penghuang+watch-mandoline_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sandbox html_viewer on Linux. This creates a font_service which does the same role as font_config_ipc_linux.cc does in content/. This lets us sandbox the html_viewer, while still being able to communicate with fontconfig. Also prewarms the ICU timezone data, along with doing all the prewarming that's done in the core_services sandbox. BUG=492524 NOPRESUBMIT=true Committed: https://crrev.com/4196dfefc131b0a77a3e02e917b852dba8faf445 Cr-Commit-Position: refs/heads/master@{#342281}

Patch Set 1 #

Patch Set 2 : Remove logging #

Patch Set 3 : Fix dangling sentences. #

Patch Set 4 : Fix html_viewer_apptests. #

Patch Set 5 : Fix android compile. #

Total comments: 3

Patch Set 6 : Style stuff. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+819 lines, -8 lines) Patch
A components/font_service/BUILD.gn View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download
A + components/font_service/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
A components/font_service/font_service_app.h View 1 chunk +53 lines, -0 lines 0 comments Download
A components/font_service/font_service_app.cc View 1 chunk +123 lines, -0 lines 0 comments Download
A + components/font_service/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/font_service/public/cpp/BUILD.gn View 2 chunks +7 lines, -2 lines 0 comments Download
A components/font_service/public/cpp/font_loader.h View 1 2 3 4 5 1 chunk +67 lines, -0 lines 0 comments Download
A components/font_service/public/cpp/font_loader.cc View 1 2 3 4 5 1 chunk +63 lines, -0 lines 0 comments Download
A components/font_service/public/cpp/font_service_thread.h View 1 2 3 4 5 1 chunk +97 lines, -0 lines 0 comments Download
A components/font_service/public/cpp/font_service_thread.cc View 1 2 3 4 5 1 chunk +158 lines, -0 lines 0 comments Download
A components/font_service/public/cpp/mapped_font_file.h View 1 chunk +54 lines, -0 lines 0 comments Download
A components/font_service/public/cpp/mapped_font_file.cc View 1 chunk +48 lines, -0 lines 0 comments Download
A + components/font_service/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A components/font_service/public/interfaces/font_service.mojom View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
M components/html_viewer/BUILD.gn View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M components/html_viewer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/html_viewer/global_state.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M components/html_viewer/html_viewer_main.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M mandoline/app/core_services_initialization.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M mandoline/services/core_services/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M mandoline/services/core_services/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M mojo/runner/child_process.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/runner/linux_sandbox.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/application_manager.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Elliot Glaysher
5 years, 4 months ago (2015-08-06 20:51:06 UTC) #2
jam
lgtm https://codereview.chromium.org/1274743004/diff/80001/components/font_service/public/cpp/font_loader.h File components/font_service/public/cpp/font_loader.h (right): https://codereview.chromium.org/1274743004/diff/80001/components/font_service/public/cpp/font_loader.h#newcode41 components/font_service/public/cpp/font_loader.h:41: FontIdentity* outFontIdentifier, nit: convention is to rename parameters ...
5 years, 4 months ago (2015-08-06 21:34:38 UTC) #3
Elliot Glaysher
(adding NOPRESUBMIT because of the copied ScopedAllowIO code.)
5 years, 4 months ago (2015-08-06 22:58:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274743004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274743004/100001
5 years, 4 months ago (2015-08-06 22:58:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/96133)
5 years, 4 months ago (2015-08-06 23:57:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274743004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274743004/100001
5 years, 4 months ago (2015-08-07 00:25:16 UTC) #11
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 4 months ago (2015-08-07 03:06:51 UTC) #12
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/4196dfefc131b0a77a3e02e917b852dba8faf445 Cr-Commit-Position: refs/heads/master@{#342281}
5 years, 4 months ago (2015-08-07 03:07:38 UTC) #13
hiroshige (private)
This CL causes compile failures on Linux buildbots due to conflict with renaming of mojo ...
5 years, 4 months ago (2015-08-07 04:10:53 UTC) #14
Nico
5 years, 4 months ago (2015-08-07 04:49:34 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1276163002/ by thakis@chromium.org.

The reason for reverting is: Doesn't build on the Linux GN bot:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/30188/s....

Powered by Google App Engine
This is Rietveld 408576698