chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java - Issue 1279873003: [Android] Add progress bar linear animation option.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java

Issue 1279873003: [Android] Add progress bar linear animation option. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/widget/ProgressAnimationLinear.java ('k') | chrome/app/generated_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java

index a53e769873d6a71f0c44a870b4d81bc3287d0a1f..ac42aea213e1392a956c0a87e9e7fcbad1630ecb 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java

@@ -106,6 +106,12 @@ public class ToolbarProgressBar extends ClipDrawableProgressBar {

mAnimationLogic = new ProgressAnimationSmooth();

} else if (TextUtils.equals(animation, "fast-start")) {

mAnimationLogic = new ProgressAnimationFastStart();

+ } else if (TextUtils.equals(animation, "linear")) {

+ mAnimationLogic = new ProgressAnimationLinear();

+ } else {

+ assert animation == null

Ted C 2015/08/07 23:11:00 Maybe just this instead of the two checks? http://

Kibeom Kim (inactive) 2015/08/07 23:35:34 Done.

+ || animation.isEmpty()

+ || TextUtils.equals(animation, "disabled");

}