Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 1279873003: [Android] Add progress bar linear animation option. (Closed)

Created:
5 years, 4 months ago by Kibeom Kim (inactive)
Modified:
5 years, 4 months ago
CC:
chromium-reviews, Ted C
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add progress bar linear animation option. For page loading time and battery efficiency, it's good to produce fewer frames. Compared to other smooth animations we already have, linear animation looks OK with fewer frames as it doesn't spend frames on smaller increments. BUG=352839 Committed: https://crrev.com/591b2b8df44a3afce25d6217cc879e26c46588d9 Cr-Commit-Position: refs/heads/master@{#342536}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use TextUtils.isEmpty #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
A chrome/android/java/src/org/chromium/chrome/browser/widget/ProgressAnimationLinear.java View 1 1 chunk +30 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Kibeom Kim (inactive)
dtrainor@chromium.org: Please review changes in tedchoc@chromium.org: Please review changes in
5 years, 4 months ago (2015-08-06 20:45:40 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279873003/1
5 years, 4 months ago (2015-08-06 20:45:57 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/87635)
5 years, 4 months ago (2015-08-06 21:17:31 UTC) #7
Ted C
lgtm https://codereview.chromium.org/1279873003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java File chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java (right): https://codereview.chromium.org/1279873003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java#newcode112 chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java:112: assert animation == null Maybe just this instead ...
5 years, 4 months ago (2015-08-07 23:11:00 UTC) #9
Kibeom Kim (inactive)
https://codereview.chromium.org/1279873003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java File chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java (right): https://codereview.chromium.org/1279873003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java#newcode112 chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java:112: assert animation == null On 2015/08/07 23:11:00, Ted C ...
5 years, 4 months ago (2015-08-07 23:35:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279873003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279873003/20001
5 years, 4 months ago (2015-08-07 23:36:52 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/96867)
5 years, 4 months ago (2015-08-08 01:31:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279873003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279873003/20001
5 years, 4 months ago (2015-08-08 17:57:41 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-08 18:50:27 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-08 18:51:20 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/591b2b8df44a3afce25d6217cc879e26c46588d9
Cr-Commit-Position: refs/heads/master@{#342536}

Powered by Google App Engine
This is Rietveld 408576698