Issue 1279873002: Merge to XFA: Add CFX_FontFaceInfo constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1279873002: Merge to XFA: Add CFX_FontFaceInfo constructor. (Closed)

Created:
5 years, 4 months ago by Tom Sepez

Modified:
5 years, 4 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Add CFX_FontFaceInfo constructor. (cherry picked from commit 905cc10ecd06bcacfefb747cc3370c72772f0e15) Original Review URL: https://codereview.chromium.org/1277883004 . TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/792d55cfe3cf046125fd69d8914ae459216a68ab

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -25 lines)			Patch
M	core/src/fxge/ge/fx_ge_fontmap.cpp	View	5 chunks	+10 lines, -17 lines	0 comments	Download
M	core/src/fxge/ge/fx_ge_linux.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	core/src/fxge/ge/text_int.h	View	1 chunk	+20 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

TBR, nearly automatic (conflict over |if !x return| following |new| that never got merged).

5 years, 4 months ago (2015-08-06 18:56:46 UTC) #1

Tom Sepez

Committed patchset #1 (id:1) manually as 792d55cfe3cf046125fd69d8914ae459216a68ab (presubmit successful).

5 years, 4 months ago (2015-08-06 18:57:08 UTC) #2

Message was sent while issue was closed.

lgtm