Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1277883004: Add CFX_FontFaceInfo constructor. (Closed)

Created:
5 years, 4 months ago by Tom Sepez
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang, Nico
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add CFX_FontFaceInfo constructor. (Having renamed CFontFaceInfo to follow naming pattern). Also cleanup some initialization-order noise in CFX_FontMapper. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/905cc10ecd06bcacfefb747cc3370c72772f0e15

Patch Set 1 #

Total comments: 2

Patch Set 2 : Put consts together #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -22 lines) Patch
M core/src/fxge/ge/fx_ge_fontmap.cpp View 5 chunks +10 lines, -14 lines 1 comment Download
M core/src/fxge/ge/fx_ge_linux.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxge/ge/text_int.h View 1 1 chunk +20 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tom Sepez
Lei, for review. Just a little tidying along the way towards fixing font disparities in ...
5 years, 4 months ago (2015-08-06 18:02:44 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1277883004/diff/1/core/src/fxge/ge/text_int.h File core/src/fxge/ge/text_int.h (right): https://codereview.chromium.org/1277883004/diff/1/core/src/fxge/ge/text_int.h#newcode86 core/src/fxge/ge/text_int.h:86: const FX_DWORD m_FontOffset; maybe put all the constants ...
5 years, 4 months ago (2015-08-06 18:29:44 UTC) #3
Tom Sepez
https://codereview.chromium.org/1277883004/diff/1/core/src/fxge/ge/text_int.h File core/src/fxge/ge/text_int.h (right): https://codereview.chromium.org/1277883004/diff/1/core/src/fxge/ge/text_int.h#newcode86 core/src/fxge/ge/text_int.h:86: const FX_DWORD m_FontOffset; On 2015/08/06 18:29:44, Lei Zhang wrote: ...
5 years, 4 months ago (2015-08-06 18:40:42 UTC) #4
Tom Sepez
Committed patchset #2 (id:20001) manually as 905cc10ecd06bcacfefb747cc3370c72772f0e15 (presubmit successful).
5 years, 4 months ago (2015-08-06 18:41:21 UTC) #5
Nico
5 years, 4 months ago (2015-08-06 20:23:27 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1277883004/diff/20001/core/src/fxge/ge/fx_ge_...
File core/src/fxge/ge/fx_ge_fontmap.cpp (right):

https://codereview.chromium.org/1277883004/diff/20001/core/src/fxge/ge/fx_ge_...
core/src/fxge/ge/fx_ge_fontmap.cpp:457: m_pFontInfo(nullptr),
This breaks the clang/win build:

..\..\third_party\pdfium\core\src\fxge\ge\fx_ge_fontmap.cpp(456,7) :  error:
field 'm_pFontInfo' will be initialized after field 'm_bListLoaded'
[-Werror,-Wreorder]
    : m_pFontInfo(nullptr),
      ^

Powered by Google App Engine
This is Rietveld 408576698