Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 1279863004: Complete SyncMessageFilter initialization after SyncChannel initialization (Closed)

Created:
5 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Complete SyncMessageFilter initialization after SyncChannel initialization This changes SyncChannel to keep track of any SyncMessageFilters it creates prior to ChannelProxy::Init being called. Once Init completes, initialization of all tracked SyncMessageFilters is completed by updating their is_channel_send_thread_safe flag. BUG=516464 R=jam@chromium.org Committed: https://crrev.com/29ade1b15c854942b553c446df18ad3f3f46a931 Cr-Commit-Position: refs/heads/master@{#342308}

Patch Set 1 #

Patch Set 2 : eh, vector instead of list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M ipc/ipc_channel_proxy.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ipc/ipc_sync_channel.h View 1 2 chunks +8 lines, -1 line 0 comments Download
M ipc/ipc_sync_channel.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M ipc/ipc_sync_message_filter.h View 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (8 generated)
Ken Rockot(use gerrit already)
5 years, 4 months ago (2015-08-06 21:22:58 UTC) #3
jam
lgtm
5 years, 4 months ago (2015-08-06 21:37:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279863004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279863004/60001
5 years, 4 months ago (2015-08-06 21:52:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/87686)
5 years, 4 months ago (2015-08-06 23:08:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279863004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279863004/60001
5 years, 4 months ago (2015-08-06 23:38:16 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_10.10_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_10.10_rel_ng/builds/2895)
5 years, 4 months ago (2015-08-07 02:32:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279863004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279863004/60001
5 years, 4 months ago (2015-08-07 05:52:50 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 4 months ago (2015-08-07 06:24:07 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 06:24:42 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/29ade1b15c854942b553c446df18ad3f3f46a931
Cr-Commit-Position: refs/heads/master@{#342308}

Powered by Google App Engine
This is Rietveld 408576698