Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1273283002: Re-enable ChannelMojo. (Closed)

Created:
5 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 4 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@is-this-real-life
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable ChannelMojo. AGAIN! Previously reverted attempts: https://codereview.chromium.org/1262503011/ https://codereview.chromium.org/1256473002/ SyncMessageFilter is set up to properly use thread-safe Send channels now, so this should stick. Maybe. BUG=500019 TBR=jam@chromium.org Committed: https://crrev.com/d34d184bd1a88043667b10cba79a5770bd2803fb Cr-Commit-Position: refs/heads/master@{#342484}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M ipc/mojo/ipc_channel_mojo.cc View 1 chunk +1 line, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273283002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273283002/40001
5 years, 4 months ago (2015-08-07 21:21:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 4 months ago (2015-08-07 23:59:55 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d34d184bd1a88043667b10cba79a5770bd2803fb Cr-Commit-Position: refs/heads/master@{#342484}
5 years, 4 months ago (2015-08-08 00:00:54 UTC) #6
Ken Rockot(use gerrit already)
5 years, 4 months ago (2015-08-08 14:29:51 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:40001) has been created in
https://codereview.chromium.org/1285463002/ by rockot@chromium.org.

The reason for reverting is: Still seeing flake on ChromeOS, and it's probably
this again..

Powered by Google App Engine
This is Rietveld 408576698