Support needed to measure user and service traffic in Chrome.

tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 14892679f4b7567384c3344b6201d15aaffe612e..bd614571db86192fca38f84753a3fb3e72639be2 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -5623,6 +5623,35 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="DataUse.NotUser" units="bytes">
+  <owner>amohammadkhan@chromium.org</owner>
+  <owner>bengr@chromium.org</owner>
+  <summary>
+    The total data use of Chrome's services. This traffic is not requested by
+    Renderer process.

[Alexei Svitkine (slow), 2015/08/31 17:26:31]

Please rephrase the last sentence, as it's a bit confusing.

Do you mean this only measures traffic requested by the browser process and not
other processes (e.g. renderer)? (If so, phrase it in that way.)

[amohammadkhan, 2015/09/01 04:52:49]

Done.

+  </summary>
+</histogram>
+
+<histogram name="DataUse.Service" units="bytes">

[Alexei Svitkine (slow), 2015/08/31 17:26:31]

I suggest naming this in a way that references it's meaning - e.g.
DataUse.MessageSize. The fact that it's by service is implified by the specific
suffixes.

[amohammadkhan, 2015/09/01 04:52:49]

Done.

+  <owner>amohammadkhan@chromium.org</owner>
+  <owner>bengr@chromium.org</owner>
+  <summary>
+    The request and reponse size of the messages exchanged by a service. The

[Alexei Svitkine (slow), 2015/08/31 17:26:31]

Over what period of time? When is it logged?

[amohammadkhan, 2015/09/01 04:52:49]

Done.

+    service name is added as a sufffix to this histogram name.
+  </summary>
+</histogram>
+
+<histogram name="DataUse.Services" enum="DataUseServices">

[Alexei Svitkine (slow), 2015/08/31 17:26:31]

Same comment as for DataUse.Service.

[amohammadkhan, 2015/09/01 04:52:49]

For this one, If I remove "services", no ServiceName is attached to it, so it
may be confusing if someone just look at its name. (ServiceNames are just
buckets, so they are not reflected in its name.)

Added comment about when it is logged.

+  <owner>amohammadkhan@chromium.org</owner>
+  <owner>bengr@chromium.org</owner>
+  <summary>
+    The request and reponse size of the messages exchanged by all the services.
+    The buckets in this histogram are services, so it makes it possible to
+    compare the use of different services in different conditions. Different
+    conditions are added as suffixes to this histogram.
+  </summary>
+</histogram>
+
 <histogram name="DataUse.Sync.Download.Bytes" enum="SyncModelTypes">
   <owner>amohammadkhan@chromium.org</owner>
   <owner>bengr@chromium.org</owner>
@@ -5671,6 +5700,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="DataUse.User" units="bytes">
+  <owner>amohammadkhan@chromium.org</owner>
+  <owner>bengr@chromium.org</owner>
+  <summary>
+    The total amount of data use of Chrome for user traffic. This traffic has
+    content::ResourceRequestInfo attached to its request.
+  </summary>
+</histogram>
+
 <histogram name="DefaultBrowser.InteractionResult"
     enum="MakeChromeDefaultResult">
   <owner>gab@chromium.org</owner>
@@ -55037,6 +55075,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
       label="Arrived at settings menu by another path: entered on, exited on"/>
 </enum>
 
+<enum name="DataUseServices" type="int">
+  <int value="0" label="Suggestions Service"/>
+</enum>
+
 <enum name="DecodedImageType" type="int">
   <int value="0" label="kImageUnknown"/>
   <int value="1" label="kImageJPEG"/>
@@ -74537,6 +74579,25 @@ To add a new entry, add it with any value and run test to compute valid value.
       name="DataReductionProxy.RequestCompletionErrorCodes.MainFrame"/>
 </histogram_suffixes>
 
+<histogram_suffixes name="DataUse.Dimensions" separator=".">
+  <suffix name="Upload.Background.NotCellular"/>

[Alexei Svitkine (slow), 2015/08/31 17:26:31]

Nit: You can have multiple levels of histogram_suffixes - just make
affected-histogram refer to the suffixed versions.

[amohammadkhan, 2015/09/01 04:52:49]

I see, but I just have two different suffixes in each level and I think using
multiple level suffixes may even make it harder to implement/understand.

+  <suffix name="Upload.Background.Cellular"/>
+  <suffix name="Upload.Foreground.NotCellular"/>
+  <suffix name="Upload.Foreground.Cellular"/>
+  <suffix name="Download.Background.NotCellular"/>
+  <suffix name="Download.Background.Cellular"/>
+  <suffix name="Download.Foreground.NotCellular"/>
+  <suffix name="Download.Foreground.Cellular"/>
+  <affected-histogram name="DataUse.NotUser"/>
+  <affected-histogram name="DataUse.Services"/>
+  <affected-histogram name="DataUse.User"/>
+</histogram_suffixes>
+
+<histogram_suffixes name="DataUse.Service.Types" separator=".">
+  <suffix name="Suggestions"/>
+  <affected-histogram name="DataUse.Service"/>
+</histogram_suffixes>
+
 <histogram_suffixes name="DefaultAppsExperiment">
   <suffix name="NoDefaultApps" label="User's without default apps installed"/>
   <suffix name="WithDefaultApps" label="User's with default apps installed"/>