components/suggestions/suggestions_service.cc - Issue 1279543002: Support needed to measure user and service traffic in Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/suggestions/suggestions_service.cc

Issue 1279543002: Support needed to measure user and service traffic in Chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@NewHistogram

Patch Set: Adding sclittle to OWNERs and little fix in ChromeNetworkDelegate test. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_use_measurement/core/data_use_user_data.h ('K') | « components/suggestions/DEPS ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/suggestions/suggestions_service.cc

diff --git a/components/suggestions/suggestions_service.cc b/components/suggestions/suggestions_service.cc

index 666ee51bcc3b01208fb16bdec746ae7fa2fb0700..1ccee32772d6d9f8998588cac705eaf3a49f38ce 100644

--- a/components/suggestions/suggestions_service.cc

+++ b/components/suggestions/suggestions_service.cc

@@ -16,6 +16,7 @@

#include "base/strings/stringprintf.h"

#include "base/thread_task_runner_handle.h"

#include "base/time/time.h"

+#include "components/data_use_measurement/core/data_use_user_data.h"

#include "components/pref_registry/pref_registry_syncable.h"

#include "components/suggestions/blacklist_store.h"

#include "components/suggestions/suggestions_store.h"

@@ -253,6 +254,10 @@ scoped_ptr<net::URLFetcher> SuggestionsService::CreateSuggestionsRequest(

const GURL& url) {

scoped_ptr<net::URLFetcher> request =

net::URLFetcher::Create(0, url, net::URLFetcher::GET, this);

+ request->SetURLRequestUserData(

+ data_use_measurement::DataUseUserData::kUserDataKey,

+ base::Bind(&data_use_measurement::CreateDataUseUserData,

+ data_use_measurement::DataUseUserData::SUGGESTIONS));

request->SetLoadFlags(net::LOAD_DISABLE_CACHE);

request->SetRequestContext(url_request_context_);

// Add Chrome experiment state to the request headers.