Issue 1279123006: Merge to XFA: Cleanup: Mark methods with the override keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1279123006: Merge to XFA: Cleanup: Mark methods with the override keyword. (Closed)

Created:
5 years, 4 months ago by Lei Zhang

Modified:
5 years, 4 months ago

Reviewers:
Nico

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Cleanup: Mark methods with the override keyword. - Delete unneeded CFFL_ComboBox::CanCopy() and friends. - Delete unneeded CFFL_FormFiller::CanCopy() and friends. - Delete unneeded CFFL_TextField::CanCopy() and friends. - Delete unneeded FormFiller::DoCopy() and friends. - Rename CFFL_FormFiller::On{Set,Kill}Focus to avoid conflicts. BUG=pdfium:185 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1283493004 . (cherry picked from commit 3a3849176aa6e2db8baf2f9367b2d96c71815319) Committed: https://pdfium.googlesource.com/pdfium/+/335e11825fcb8520f68ac668f8dacd9b48f05804

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -208 lines)			Patch
M	core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/include/formfiller/FFL_ComboBox.h	View	1	1 chunk	+30 lines, -39 lines	0 comments	Download
M	fpdfsdk/include/formfiller/FFL_FormFiller.h	View	1	3 chunks	+11 lines, -20 lines	0 comments	Download
M	fpdfsdk/include/formfiller/FFL_IFormFiller.h	View	1	4 chunks	+26 lines, -25 lines	0 comments	Download
M	fpdfsdk/include/formfiller/FFL_TextField.h	View	1	1 chunk	+29 lines, -37 lines	0 comments	Download
M	fpdfsdk/include/fsdk_baseform.h	View		1 chunk	+13 lines, -12 lines	0 comments	Download
M	fpdfsdk/src/formfiller/FFL_ComboBox.cpp	View	1	1 chunk	+0 lines, -18 lines	0 comments	Download
M	fpdfsdk/src/formfiller/FFL_FormFiller.cpp	View	1	4 chunks	+5 lines, -21 lines	0 comments	Download
M	fpdfsdk/src/formfiller/FFL_IFormFiller.cpp	View	1	3 chunks	+20 lines, -22 lines	0 comments	Download
M	fpdfsdk/src/formfiller/FFL_TextField.cpp	View	1	1 chunk	+0 lines, -13 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

TBR There's still more override warnings on the XFA branch after this.

5 years, 4 months ago (2015-08-10 08:07:14 UTC) #1

Lei Zhang

5 years, 4 months ago (2015-08-10 08:07:23 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
335e11825fcb8520f68ac668f8dacd9b48f05804 (presubmit successful).