Cleanup: Mark methods with the override keyword.

Cleanup: Mark methods with the override keyword.

- Delete unneeded CFFL_ComboBox::CanCopy() and friends.
- Delete unneeded CFFL_FormFiller::CanCopy() and friends.
- Delete unneeded CFFL_TextField::CanCopy() and friends.
- Delete unneeded FormFiller::DoCopy() and friends.
- Rename CFFL_FormFiller::On{Set,Kill}Focus to avoid conflicts.

BUG=pdfium:185
R=thakis@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/3a3849176aa6e2db8baf2f9367b2d96c71815319

[Lei Zhang, 2015-08-08 23:09:10]

thestig@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-08-08 23:47:40]

lgtm, slightly stampy

I'd expand the CL description a bit and mention renames and whatnot.

Thanks! :-)

https://codereview.chromium.org/1283493004/diff/1/fpdfsdk/include/formfiller/...
File fpdfsdk/include/formfiller/FFL_ComboBox.h (left):

https://codereview.chromium.org/1283493004/diff/1/fpdfsdk/include/formfiller/...
fpdfsdk/include/formfiller/FFL_ComboBox.h:63: virtual FX_BOOL
CanCopy(CPDFSDK_Document* pDocument);
where did this block go?

https://codereview.chromium.org/1283493004/diff/1/fpdfsdk/include/formfiller/...
File fpdfsdk/include/formfiller/FFL_FormFiller.h (right):

https://codereview.chromium.org/1283493004/diff/1/fpdfsdk/include/formfiller/...
fpdfsdk/include/formfiller/FFL_FormFiller.h:106: virtual void
OnKeyStroke(FX_BOOL bKeyDown, FX_DWORD nFlag);
Is this supposed to be an override? If not, why the new param?

[Lei Zhang, 2015-08-10 07:03:22]

https://codereview.chromium.org/1283493004/diff/1/fpdfsdk/include/formfiller/...
File fpdfsdk/include/formfiller/FFL_ComboBox.h (left):

https://codereview.chromium.org/1283493004/diff/1/fpdfsdk/include/formfiller/...
fpdfsdk/include/formfiller/FFL_ComboBox.h:63: virtual FX_BOOL
CanCopy(CPDFSDK_Document* pDocument);
On 2015/08/08 23:47:40, Nico (hiding) wrote:
> where did this block go?

CFFL_ComboBox::CanCopy() and friends are just no-ops. So I deleted them.

https://codereview.chromium.org/1283493004/diff/1/fpdfsdk/include/formfiller/...
File fpdfsdk/include/formfiller/FFL_FormFiller.h (right):

https://codereview.chromium.org/1283493004/diff/1/fpdfsdk/include/formfiller/...
fpdfsdk/include/formfiller/FFL_FormFiller.h:106: virtual void
OnKeyStroke(FX_BOOL bKeyDown, FX_DWORD nFlag);
On 2015/08/08 23:47:40, Nico (hiding) wrote:
> Is this supposed to be an override? If not, why the new param?

No, CFFL_ListBox which inherits from CFFL_FormFiller is suppose to override
this.

[Lei Zhang, 2015-08-10 07:06:44]

Committed patchset #1 (id:1) manually as
3a3849176aa6e2db8baf2f9367b2d96c71815319 (presubmit successful).