Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: Source/bindings/core/v8/V8DOMConfiguration.h

Issue 1278983003: Adding allocator annotations to blink classes and structs. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed patch conflict Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8DOMActivityLogger.h ('k') | Source/bindings/core/v8/V8DOMWrapper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8DOMConfiguration.h
diff --git a/Source/bindings/core/v8/V8DOMConfiguration.h b/Source/bindings/core/v8/V8DOMConfiguration.h
index 80738cf5e3eb1b0d666fb712a34432c12b95f6f3..979b78b622f526d56b5366ff1785f9d9f5556b6a 100644
--- a/Source/bindings/core/v8/V8DOMConfiguration.h
+++ b/Source/bindings/core/v8/V8DOMConfiguration.h
@@ -37,6 +37,8 @@
namespace blink {
class CORE_EXPORT V8DOMConfiguration final {
+ DISALLOW_ALLOCATION();
+ WTF_MAKE_NONCOPYABLE(V8DOMConfiguration);
public:
// The following Configuration structs and install methods are used for
// setting multiple properties on ObjectTemplate / FunctionTemplate, used
@@ -64,6 +66,8 @@ public:
// AttributeConfiguration translates into calls to SetAccessor() on either
// the instance or the prototype ObjectTemplate, based on |instanceOrPrototypeConfiguration|.
struct AttributeConfiguration {
+ WTF_MAKE_NONCOPYABLE(AttributeConfiguration);
+ DISALLOW_ALLOCATION();
const char* const name;
v8::AccessorNameGetterCallback getter;
v8::AccessorNameSetterCallback setter;
@@ -84,6 +88,8 @@ public:
// AccessorConfiguration translates into calls to SetAccessorProperty()
// on prototype ObjectTemplate.
struct AccessorConfiguration {
+ WTF_MAKE_NONCOPYABLE(AccessorConfiguration);
+ DISALLOW_ALLOCATION();
const char* const name;
v8::FunctionCallback getter;
v8::FunctionCallback setter;
@@ -117,6 +123,8 @@ public:
// object's constants. It sets the constant on both the FunctionTemplate and
// the ObjectTemplate. PropertyAttributes is always ReadOnly.
struct ConstantConfiguration {
+ WTF_MAKE_NONCOPYABLE(ConstantConfiguration);
+ DISALLOW_ALLOCATION();
const char* const name;
int ivalue;
double dvalue;
@@ -142,6 +150,8 @@ public:
// object's callbacks. It sets the method on both the FunctionTemplate or
// the ObjectTemplate.
struct MethodConfiguration {
+ WTF_MAKE_NONCOPYABLE(MethodConfiguration);
+ DISALLOW_ALLOCATION();
v8::Local<v8::Name> methodName(v8::Isolate* isolate) const { return v8AtomicString(isolate, name); }
v8::FunctionCallback callbackForWorld(const DOMWrapperWorld& world) const
{
@@ -156,6 +166,8 @@ public:
};
struct SymbolKeyedMethodConfiguration {
+ WTF_MAKE_NONCOPYABLE(SymbolKeyedMethodConfiguration);
+ DISALLOW_ALLOCATION();
v8::Local<v8::Name> methodName(v8::Isolate* isolate) const { return getSymbol(isolate); }
v8::FunctionCallback callbackForWorld(const DOMWrapperWorld&) const
{
« no previous file with comments | « Source/bindings/core/v8/V8DOMActivityLogger.h ('k') | Source/bindings/core/v8/V8DOMWrapper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698