content/shell/renderer/layout_test/blink_test_helpers.cc - Issue 1278973003: Revert of Update SplitString calls to new form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/layout_test/blink_test_helpers.cc

Issue 1278973003: Revert of Update SplitString calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/renderer/layout_test/blink_test_helpers.cc

diff --git a/content/shell/renderer/layout_test/blink_test_helpers.cc b/content/shell/renderer/layout_test/blink_test_helpers.cc

index 1cd3e2f48dc0a33707c9239ef2029628c17712d6..6719010a720e11bc25b9f2cf5e744891b5cb1095 100644

--- a/content/shell/renderer/layout_test/blink_test_helpers.cc

+++ b/content/shell/renderer/layout_test/blink_test_helpers.cc

@@ -126,9 +126,10 @@

const base::CommandLine& command_line =

*base::CommandLine::ForCurrentProcess();

if (command_line.HasSwitch(switches::kRegisterFontFiles)) {

- files = base::SplitString(

+ base::SplitString(

command_line.GetSwitchValueASCII(switches::kRegisterFontFiles),

- ";", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

+ ';',

+ &files);

}

return files;

}