content/renderer/render_view_impl.cc - Issue 1278973003: Revert of Update SplitString calls to new form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 1278973003: Revert of Update SplitString calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index e0390bf9f991829f38430ce7ecd5e9ff180f73de..1b8e1d95be8ad8cefea7bea77ab60a512b4c22bf 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -600,9 +600,10 @@

if (!command_line.HasSwitch(switches::kBlinkSettings))

return;

- std::vector<std::string> blink_settings = base::SplitString(

- command_line.GetSwitchValueASCII(switches::kBlinkSettings),

- ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

+ std::vector<std::string> blink_settings;

+ base::SplitString(

+ command_line.GetSwitchValueASCII(switches::kBlinkSettings), ',',

+ &blink_settings);

for (const std::string& setting : blink_settings) {

size_t pos = setting.find('=');

settings->setFromStrings(