Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1278643006: Make GrBatch carry its own GrPipeline (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 4 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -277 lines) Patch
M include/core/SkTemplates.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrBufferedDrawTarget.h View 4 chunks +13 lines, -14 lines 0 comments Download
M src/gpu/GrBufferedDrawTarget.cpp View 5 chunks +12 lines, -42 lines 0 comments Download
M src/gpu/GrCommandBuilder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 4 chunks +26 lines, -33 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 4 chunks +32 lines, -40 lines 0 comments Download
M src/gpu/GrImmediateDrawTarget.h View 3 chunks +1 line, -8 lines 0 comments Download
M src/gpu/GrImmediateDrawTarget.cpp View 3 chunks +7 lines, -36 lines 0 comments Download
M src/gpu/GrInOrderCommandBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderCommandBuilder.cpp View 1 chunk +3 lines, -8 lines 0 comments Download
M src/gpu/GrPipeline.h View 2 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 3 chunks +15 lines, -22 lines 0 comments Download
M src/gpu/GrReorderCommandBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrReorderCommandBuilder.cpp View 1 5 chunks +12 lines, -15 lines 0 comments Download
M src/gpu/GrTargetCommands.h View 1 8 chunks +22 lines, -23 lines 0 comments Download
M src/gpu/GrTargetCommands.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrBatch.h View 1 3 chunks +13 lines, -19 lines 0 comments Download
M src/gpu/batches/GrBatch.cpp View 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bsalomon
5 years, 4 months ago (2015-08-11 21:32:52 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278643006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278643006/20001
5 years, 4 months ago (2015-08-11 21:34:23 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-11 21:41:29 UTC) #6
joshualitt
On 2015/08/11 21:34:23, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 4 months ago (2015-08-11 21:46:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278643006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278643006/20001
5 years, 4 months ago (2015-08-11 21:47:07 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 21:47:45 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a387a11f9e10ee828fd0e0257cc3ee3f6262f7ca

Powered by Google App Engine
This is Rietveld 408576698