Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: src/gpu/GrPipeline.h

Issue 1278643006: Make GrBatch carry its own GrPipeline (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: more Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/GrInOrderCommandBuilder.cpp ('k') | src/gpu/GrPipeline.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrPipeline.h
diff --git a/src/gpu/GrPipeline.h b/src/gpu/GrPipeline.h
index 497554bd34e628592f888211ca0b85d7cf4af3b8..ef81d216a62d277a213558bfe6a6c7d9b266f7a4 100644
--- a/src/gpu/GrPipeline.h
+++ b/src/gpu/GrPipeline.h
@@ -29,15 +29,17 @@ class GrPipelineBuilder;
*/
class GrPipeline : public GrNonAtomicRef {
public:
+ struct CreateArgs {
+ const GrPipelineBuilder* fPipelineBuilder;
+ const GrCaps* fCaps;
+ GrProcOptInfo fColorPOI;
+ GrProcOptInfo fCoveragePOI;
+ const GrScissorState* fScissor;
+ GrXferProcessor::DstTexture fDstTexture;
+ };
+
/** Creates a pipeline into a pre-allocated buffer */
- static GrPipeline* CreateAt(void* memory,
- const GrPipelineBuilder&,
- const GrProcOptInfo& colorPOI,
- const GrProcOptInfo& coveragePOI,
- const GrCaps&,
- const GrScissorState&,
- const GrXferProcessor::DstTexture*,
- GrPipelineOptimizations*);
+ static GrPipeline* CreateAt(void* memory, const CreateArgs&, GrPipelineOptimizations*);
/*
* Returns true if these pipelines are equivalent. Coord transforms may be applied either on
@@ -87,8 +89,6 @@ public:
bool isDitherState() const { return SkToBool(fFlags & kDither_Flag); }
bool isHWAntialiasState() const { return SkToBool(fFlags & kHWAA_Flag); }
bool snapVerticesToPixelCenters() const { return SkToBool(fFlags & kSnapVertices_Flag); }
- // Skip any draws that refer to this pipeline (they should be a no-op).
- bool mustSkip() const { return NULL == this->getRenderTarget(); }
/**
* Gets whether the target is drawing clockwise, counterclockwise,
« no previous file with comments | « src/gpu/GrInOrderCommandBuilder.cpp ('k') | src/gpu/GrPipeline.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698