Source/core/layout/LayoutBoxModelObject.cpp - Issue 1278543002: Include the whole outline into visual overflow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBoxModelObject.cpp

Issue 1278543002: Include the whole outline into visual overflow (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/LayoutBoxModelObject.cpp

diff --git a/Source/core/layout/LayoutBoxModelObject.cpp b/Source/core/layout/LayoutBoxModelObject.cpp

index 322bb7e4a5ebb6323025e044c5ed1568a0ac6880..4925fb0d967a18fe712386614525043c4115fb02 100644

--- a/Source/core/layout/LayoutBoxModelObject.cpp

+++ b/Source/core/layout/LayoutBoxModelObject.cpp

@@ -414,6 +414,11 @@ void LayoutBoxModelObject::addOutlineRectsForDescendant(const LayoutObject& desc

return;

}

+ if (descendant.isLayoutInline()) {

+ toLayoutInline(descendant).addOutlineRectsForChildrenAndContinuations(rects, additionalOffset);

+ return;

chrishtr 2015/08/07 04:52:10 Can the refactor you referred to be made into its

Xianzhu 2015/08/07 16:25:37 Done. Ptal: https://codereview.chromium.org/128054

+ }

descendant.addOutlineRects(rects, additionalOffset);

}