Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: Source/core/layout/LayoutInline.h

Issue 1278543002: Include the whole outline into visual overflow (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/layout/LayoutInline.h
diff --git a/Source/core/layout/LayoutInline.h b/Source/core/layout/LayoutInline.h
index 3193e884662bf7f525567a3a755f191542531b9f..cdee488d95d2f3d220047887204236ce7d7d168e 100644
--- a/Source/core/layout/LayoutInline.h
+++ b/Source/core/layout/LayoutInline.h
@@ -87,6 +87,10 @@ public:
LayoutSize offsetForInFlowPositionedInline(const LayoutBox& child) const;
void addOutlineRects(Vector<LayoutRect>&, const LayoutPoint& additionalOffset) const final;
+ // The following methods are called from the container if it has already added outline rects for line boxes
+ // and/or children of this LayoutInline.
+ void addOutlineRectsForChildrenAndContinuations(Vector<LayoutRect>&, const LayoutPoint& additionalOffset) const;
+ void addOutlineRectsForContinuations(Vector<LayoutRect>&, const LayoutPoint& additionalOffset) const;
using LayoutBoxModelObject::continuation;
using LayoutBoxModelObject::setContinuation;
@@ -152,7 +156,6 @@ private:
LayoutRect absoluteClippedOverflowRect() const override;
LayoutRect clippedOverflowRectForPaintInvalidation(const LayoutBoxModelObject* paintInvalidationContainer, const PaintInvalidationState* = nullptr) const override;
- LayoutRect rectWithOutlineForPaintInvalidation(const LayoutBoxModelObject* paintInvalidationContainer, LayoutUnit outlineWidth, const PaintInvalidationState* = nullptr) const final;
void mapRectToPaintInvalidationBacking(const LayoutBoxModelObject* paintInvalidationContainer, LayoutRect&, const PaintInvalidationState*) const final;
// This method differs from clippedOverflowRectForPaintInvalidation in that it includes

Powered by Google App Engine
This is Rietveld 408576698