Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 127853003: Fix d8's Shell::ReadBuffer after r18227 (Closed)

Created:
6 years, 11 months ago by Jakob Kummerow
Modified:
6 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix d8's Shell::ReadBuffer after r18227 BUG=v8:3085 LOG=N R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18482

Patch Set 1 #

Patch Set 2 : year++ ;-) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M src/d8.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + test/mjsunit/regress/d8-readbuffer.js View 1 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
6 years, 11 months ago (2014-01-08 09:31:33 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 11 months ago (2014-01-08 09:47:47 UTC) #2
Jakob Kummerow
6 years, 11 months ago (2014-01-08 09:48:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r18482 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698