Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: src/d8.cc

Issue 127853003: Fix d8's Shell::ReadBuffer after r18227 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: year++ ;-) Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/d8-readbuffer.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index 73e438b10d694ff72638a73fdbcf47f22bb74ada..8ac13cf41019c47a53d292c4bee896be39b44d74 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -1133,7 +1133,8 @@ void Shell::ReadBuffer(const v8::FunctionCallbackInfo<v8::Value>& args) {
Throw(args.GetIsolate(), "Error reading file");
return;
}
- Handle<v8::ArrayBuffer> buffer = ArrayBuffer::New(isolate, data, length);
+ Handle<v8::ArrayBuffer> buffer =
+ ArrayBuffer::New(isolate, data->data, length);
data->handle.Reset(isolate, buffer);
data->handle.SetWeak(data, ReadBufferWeakCallback);
data->handle.MarkIndependent();
« no previous file with comments | « no previous file | test/mjsunit/regress/d8-readbuffer.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698