chrome/browser/metrics/chrome_metrics_service_client.cc - Issue 1278473002: Abstract notion of off-the-record in OmniboxMetricsProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 1278473002: Abstract notion of off-the-record in OmniboxMetricsProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@omnibox_metrics_provider_notification

Patch Set: Move comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/metrics/chrome_metrics_service_client.cc

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc

index 7087add4ead1e7ff20e43a992778e47a428838e0..3f7a88858d3179153c1d7fed1d3bdb09e27a05ba 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.cc

+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc

@@ -346,8 +346,12 @@ void ChromeMetricsServiceClient::Initialize() {

scoped_ptr<metrics::MetricsProvider>(new metrics::NetworkMetricsProvider(

content::BrowserThread::GetBlockingPool())));

+ // Currently, we configure OmniboxMetricsProvider to not log events to UMA

+ // if there is a single incognito session visible. In the future, it may

+ // be worth revisiting this to still log events from non-incognito sessions.

metrics_service_->RegisterMetricsProvider(

- scoped_ptr<metrics::MetricsProvider>(new OmniboxMetricsProvider));

+ scoped_ptr<metrics::MetricsProvider>(new OmniboxMetricsProvider(

+ base::Bind(&chrome::IsOffTheRecordSessionActive))));

metrics_service_->RegisterMetricsProvider(

scoped_ptr<metrics::MetricsProvider>(new ChromeStabilityMetricsProvider));

metrics_service_->RegisterMetricsProvider(

« no previous file with comments | « no previous file | chrome/browser/metrics/omnibox_metrics_provider.h » ('j') | chrome/browser/metrics/omnibox_metrics_provider.h » ('J')