Abstract notion of off-the-record in OmniboxMetricsProvider

chrome/browser/metrics/omnibox_metrics_provider.h

Index: chrome/browser/metrics/omnibox_metrics_provider.h
diff --git a/chrome/browser/metrics/omnibox_metrics_provider.h b/chrome/browser/metrics/omnibox_metrics_provider.h
index 875f616eaac4778f71ae107057f4152dfa61ca8a..9de565d5a87006603bc992dba0eeefae1271f9f7 100644
--- a/chrome/browser/metrics/omnibox_metrics_provider.h
+++ b/chrome/browser/metrics/omnibox_metrics_provider.h
@@ -16,7 +16,8 @@ struct OmniboxLog;
 // section of the UMA proto.
 class OmniboxMetricsProvider : public metrics::MetricsProvider {
  public:
-  OmniboxMetricsProvider();
+  OmniboxMetricsProvider(

[Alexei Svitkine (slow), 2015/08/05 15:47:45]

Nit: explicit

[blundell, 2015/08/07 06:24:23]

Done.

+      const base::Callback<bool(void)>& is_off_the_record_callback);
   ~OmniboxMetricsProvider() override;
 
   // metrics::MetricsDataProvider:
@@ -40,6 +41,10 @@ class OmniboxMetricsProvider : public metrics::MetricsProvider {
   // proto when ProvideGeneralMetrics() is called.
   metrics::ChromeUserMetricsExtension omnibox_events_cache;
 
+  // Callback passed in from the embedder that returns whether the user is
+  // currently operating off-the-record.
+  base::Callback<bool(void)> is_off_the_record_callback_;

[Alexei Svitkine (slow), 2015/08/05 15:47:45]

Nit: const

[blundell, 2015/08/07 06:24:23]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(OmniboxMetricsProvider);
 };