Abstract notion of off-the-record in OmniboxMetricsProvider

Abstract notion of off-the-record in OmniboxMetricsProvider

OmniboxMetricsProvider will be shared with iOS, which is decoupling from
//chrome. This CL abstracts the usage of chrome::IsOffTheRecordSessionActive()
with a callback that is passed in from the creator of OmniboxMetricsProvider.

BUG=508022
Committed: https://crrev.com/b18b341ddae2051da721b9ddf40b884e44819910
Cr-Commit-Position: refs/heads/master@{#342342}

[blundell, 2015-08-05 15:38:22]

blundell@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2015-08-05 15:47:45]

lgtm % comments

Thanks!

https://codereview.chromium.org/1278473002/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/omnibox_metrics_provider.h (right):

https://codereview.chromium.org/1278473002/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/omnibox_metrics_provider.h:19: OmniboxMetricsProvider(
Nit: explicit

https://codereview.chromium.org/1278473002/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/omnibox_metrics_provider.h:46: base::Callback<bool(void)>
is_off_the_record_callback_;
Nit: const

[blundell, 2015-08-07 06:24:23]

https://codereview.chromium.org/1278473002/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/omnibox_metrics_provider.h (right):

https://codereview.chromium.org/1278473002/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/omnibox_metrics_provider.h:19: OmniboxMetricsProvider(
On 2015/08/05 15:47:45, Alexei Svitkine wrote:
> Nit: explicit

Done.

https://codereview.chromium.org/1278473002/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/omnibox_metrics_provider.h:46: base::Callback<bool(void)>
is_off_the_record_callback_;
On 2015/08/05 15:47:45, Alexei Svitkine wrote:
> Nit: const

Done.

[blundell, 2015-08-07 09:51:56]

The CQ bit was checked by blundell@chromium.org

[blundell, 2015-08-07 09:51:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1278473002/#ps100001
(title: "Fix")

[commit-bot: I haz the power, 2015-08-07 09:52:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1278473002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1278473002/100001

[commit-bot: I haz the power, 2015-08-07 11:03:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-07 11:03:39]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[blundell, 2015-08-07 11:04:04]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2015-08-07 11:04:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1278473002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1278473002/100001

[commit-bot: I haz the power, 2015-08-07 12:40:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-07 12:40:14]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[blundell, 2015-08-07 12:42:13]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2015-08-07 12:42:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1278473002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1278473002/100001

[commit-bot: I haz the power, 2015-08-07 13:25:51]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-08-07 13:26:34]

Patchset 6 (id:??) landed as
https://crrev.com/b18b341ddae2051da721b9ddf40b884e44819910
Cr-Commit-Position: refs/heads/master@{#342342}