Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Side by Side Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 1278473002: Abstract notion of off-the-record in OmniboxMetricsProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@omnibox_metrics_provider_notification
Patch Set: Fix Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/omnibox_metrics_provider.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/chrome_metrics_service_client.h" 5 #include "chrome/browser/metrics/chrome_metrics_service_client.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 328 matching lines...) Expand 10 before | Expand all | Expand 10 after
339 // Register metrics providers. 339 // Register metrics providers.
340 #if defined(ENABLE_EXTENSIONS) 340 #if defined(ENABLE_EXTENSIONS)
341 metrics_service_->RegisterMetricsProvider( 341 metrics_service_->RegisterMetricsProvider(
342 scoped_ptr<metrics::MetricsProvider>( 342 scoped_ptr<metrics::MetricsProvider>(
343 new ExtensionsMetricsProvider(metrics_state_manager_))); 343 new ExtensionsMetricsProvider(metrics_state_manager_)));
344 #endif 344 #endif
345 metrics_service_->RegisterMetricsProvider( 345 metrics_service_->RegisterMetricsProvider(
346 scoped_ptr<metrics::MetricsProvider>(new metrics::NetworkMetricsProvider( 346 scoped_ptr<metrics::MetricsProvider>(new metrics::NetworkMetricsProvider(
347 content::BrowserThread::GetBlockingPool()))); 347 content::BrowserThread::GetBlockingPool())));
348 348
349 // Currently, we configure OmniboxMetricsProvider to not log events to UMA
350 // if there is a single incognito session visible. In the future, it may
351 // be worth revisiting this to still log events from non-incognito sessions.
349 metrics_service_->RegisterMetricsProvider( 352 metrics_service_->RegisterMetricsProvider(
350 scoped_ptr<metrics::MetricsProvider>(new OmniboxMetricsProvider)); 353 scoped_ptr<metrics::MetricsProvider>(new OmniboxMetricsProvider(
354 base::Bind(&chrome::IsOffTheRecordSessionActive))));
351 metrics_service_->RegisterMetricsProvider( 355 metrics_service_->RegisterMetricsProvider(
352 scoped_ptr<metrics::MetricsProvider>(new ChromeStabilityMetricsProvider)); 356 scoped_ptr<metrics::MetricsProvider>(new ChromeStabilityMetricsProvider));
353 metrics_service_->RegisterMetricsProvider( 357 metrics_service_->RegisterMetricsProvider(
354 scoped_ptr<metrics::MetricsProvider>(new metrics::GPUMetricsProvider)); 358 scoped_ptr<metrics::MetricsProvider>(new metrics::GPUMetricsProvider));
355 359
356 drive_metrics_provider_ = new metrics::DriveMetricsProvider( 360 drive_metrics_provider_ = new metrics::DriveMetricsProvider(
357 content::BrowserThread::GetMessageLoopProxyForThread( 361 content::BrowserThread::GetMessageLoopProxyForThread(
358 content::BrowserThread::FILE), 362 content::BrowserThread::FILE),
359 chrome::FILE_LOCAL_STATE); 363 chrome::FILE_LOCAL_STATE);
360 metrics_service_->RegisterMetricsProvider( 364 metrics_service_->RegisterMetricsProvider(
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
608 case content::NOTIFICATION_LOAD_START: 612 case content::NOTIFICATION_LOAD_START:
609 case content::NOTIFICATION_RENDERER_PROCESS_CLOSED: 613 case content::NOTIFICATION_RENDERER_PROCESS_CLOSED:
610 case content::NOTIFICATION_RENDER_WIDGET_HOST_HANG: 614 case content::NOTIFICATION_RENDER_WIDGET_HOST_HANG:
611 metrics_service_->OnApplicationNotIdle(); 615 metrics_service_->OnApplicationNotIdle();
612 break; 616 break;
613 617
614 default: 618 default:
615 NOTREACHED(); 619 NOTREACHED();
616 } 620 }
617 } 621 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/metrics/omnibox_metrics_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698