Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: ios/chrome/browser/omnibox/omnibox_event_global_tracker.h

Issue 1278433002: Eliminate OmniboxMetricsProvider listening to notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@componentize_omnibox
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/omnibox/omnibox_event_global_tracker.h
diff --git a/ios/chrome/browser/omnibox/omnibox_event_global_tracker.h b/ios/chrome/browser/omnibox/omnibox_event_global_tracker.h
deleted file mode 100644
index d174910270d1a1de25ffa912e142cf0cd1676ff8..0000000000000000000000000000000000000000
--- a/ios/chrome/browser/omnibox/omnibox_event_global_tracker.h
+++ /dev/null
@@ -1,48 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef IOS_CHROME_BROWSER_OMNIBOX_OMNIBOX_EVENT_GLOBAL_TRACKER_H_
-#define IOS_CHROME_BROWSER_OMNIBOX_OMNIBOX_EVENT_GLOBAL_TRACKER_H_
-
-#include "base/callback_list.h"
-#include "base/macros.h"
-#include "base/memory/scoped_ptr.h"
-
-template <typename T>
-struct DefaultSingletonTraits;
-
-struct OmniboxLog;
-
-// Omnibox code tracks events on a per-BrowserState basis, but there are
-// several clients who need to observe these events for all BrowserStates.
-// This class serves as an intermediary to bridge the gap: omnibox code calls
-// the OmniboxEventGlobalTracker singleton on an event of interest, and it
-// then forwards the event to its registered observers.
-class OmniboxEventGlobalTracker {
- public:
- typedef base::Callback<void(OmniboxLog*)> OnURLOpenedCallback;
-
- // Returns the instance of OmniboxEventGlobalTracker.
- static OmniboxEventGlobalTracker* GetInstance();
-
- // Registers |cb| to be invoked when user open an URL from the omnibox.
- scoped_ptr<base::CallbackList<void(OmniboxLog*)>::Subscription>
- RegisterCallback(const OnURLOpenedCallback& cb);
-
- // Called to notify all registered callbacks that an URL was opened from
- // the omnibox.
- void OnURLOpened(OmniboxLog* log);
-
- private:
- friend struct DefaultSingletonTraits<OmniboxEventGlobalTracker>;
-
- OmniboxEventGlobalTracker();
- ~OmniboxEventGlobalTracker();
-
- base::CallbackList<void(OmniboxLog*)> on_url_opened_callback_list_;
-
- DISALLOW_COPY_AND_ASSIGN(OmniboxEventGlobalTracker);
-};
-
-#endif // IOS_CHROME_BROWSER_OMNIBOX_OMNIBOX_EVENT_GLOBAL_TRACKER_H_

Powered by Google App Engine
This is Rietveld 408576698