ios/chrome/ios_chrome.gyp - Issue 1278433002: Eliminate OmniboxMetricsProvider listening to notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/ios_chrome.gyp

Issue 1278433002: Eliminate OmniboxMetricsProvider listening to notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@componentize_omnibox

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/ios_chrome.gyp

diff --git a/ios/chrome/ios_chrome.gyp b/ios/chrome/ios_chrome.gyp

index 67d50629ad1194909788430b01677940cd152eb3..7fd472c916e072e3785b906118d3adf6e1d507b8 100644

--- a/ios/chrome/ios_chrome.gyp

+++ b/ios/chrome/ios_chrome.gyp

@@ -270,10 +270,6 @@

'browser/net/metrics_network_client_manager.mm',

'browser/net/retryable_url_fetcher.h',

'browser/net/retryable_url_fetcher.mm',

- 'browser/omnibox/omnibox_event_global_tracker.cc',

- 'browser/omnibox/omnibox_event_global_tracker.h',

- 'browser/open_from_clipboard/create_clipboard_recent_content.h',

sdefresne 2015/08/07 15:30:09 Why did you remove browser/open_from_clipboard/cre

blundell 2015/08/07 15:34:17 Oops, bad rebase. https://codereview.chromium.org/

- 'browser/open_from_clipboard/create_clipboard_recent_content.mm',

'browser/passwords/password_generation_utils.h',

'browser/passwords/password_generation_utils.mm',

'browser/pref_names.cc',

« no previous file with comments | « ios/chrome/browser/omnibox/omnibox_event_global_tracker.cc ('k') | no next file » | no next file with comments »