Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: gpu/command_buffer/service/in_process_command_buffer.h

Issue 1278333003: Fix crash caused by concurrent access to framebuffer_combo_complete_map_. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/in_process_command_buffer.h
diff --git a/gpu/command_buffer/service/in_process_command_buffer.h b/gpu/command_buffer/service/in_process_command_buffer.h
index 4dfee1984fa48cd23c1b7431a85e7a9575e52481..79c81e0bfb39d94bb3e253041dd805b88d7355ff 100644
--- a/gpu/command_buffer/service/in_process_command_buffer.h
+++ b/gpu/command_buffer/service/in_process_command_buffer.h
@@ -51,6 +51,7 @@ class SyncPointManager;
class ValueStateMap;
namespace gles2 {
+class FramebufferCompletenessCache;
class GLES2Decoder;
class MailboxManager;
class ShaderTranslatorCache;
@@ -144,6 +145,8 @@ class GPU_EXPORT InProcessCommandBuffer : public CommandBuffer,
virtual bool UseVirtualizedGLContexts() = 0;
virtual scoped_refptr<gles2::ShaderTranslatorCache>
shader_translator_cache() = 0;
+ virtual scoped_refptr<gles2::FramebufferCompletenessCache>
+ framebuffer_completeness_cache() = 0;
virtual SyncPointManager* sync_point_manager() = 0;
scoped_refptr<gfx::GLShareGroup> share_group();
scoped_refptr<gles2::MailboxManager> mailbox_manager();
@@ -279,6 +282,8 @@ class GPU_EXPORT GpuInProcessThread
bool UseVirtualizedGLContexts() override;
scoped_refptr<gles2::ShaderTranslatorCache> shader_translator_cache()
override;
+ scoped_refptr<gles2::FramebufferCompletenessCache>
+ framebuffer_completeness_cache() override;
SyncPointManager* sync_point_manager() override;
private:
@@ -287,6 +292,8 @@ class GPU_EXPORT GpuInProcessThread
SyncPointManager* sync_point_manager_; // Non-owning.
scoped_refptr<gpu::gles2::ShaderTranslatorCache> shader_translator_cache_;
+ scoped_refptr<gpu::gles2::FramebufferCompletenessCache>
+ framebuffer_completeness_cache_;
DISALLOW_COPY_AND_ASSIGN(GpuInProcessThread);
};
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc ('k') | gpu/command_buffer/service/in_process_command_buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698