Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1278203002: Fix accessibility tests on Mac 10.10 (Closed)

Created:
5 years, 4 months ago by dmazzoni
Modified:
5 years, 4 months ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix accessibility tests on Mac 10.10 The role description for "check box" is inconsistent between versions, so use our own string rather than the system string. AccessibilityInputDateTimeLocal is too OS-version-dependent, just disable it on Mac for now, as it has some coverage on other platforms. BUG=513883 Committed: https://crrev.com/bd1d6438cb77461e99edb3bae1623e6dbbc56c27 Cr-Commit-Position: refs/heads/master@{#342466}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M content/app/strings/content_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M content/test/data/accessibility/aria/aria-checkbox-expected-mac.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/data/accessibility/aria/aria-checked-expected-mac.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/aria/aria-label-expected-mac.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/input-checkbox-expected-mac.txt View 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
dmazzoni
5 years, 4 months ago (2015-08-07 19:49:56 UTC) #2
Avi (use Gerrit)
lgtm ok
5 years, 4 months ago (2015-08-07 20:18:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278203002/1
5 years, 4 months ago (2015-08-07 20:55:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 22:45:21 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 22:46:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd1d6438cb77461e99edb3bae1623e6dbbc56c27
Cr-Commit-Position: refs/heads/master@{#342466}

Powered by Google App Engine
This is Rietveld 408576698