content/browser/accessibility/dump_accessibility_tree_browsertest.cc - Issue 1278203002: Fix accessibility tests on Mac 10.10

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/dump_accessibility_tree_browsertest.cc

Issue 1278203002: Fix accessibility tests on Mac 10.10 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_cocoa.mm ('k') | content/test/data/accessibility/aria/aria-checkbox-expected-mac.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/dump_accessibility_tree_browsertest.cc

diff --git a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc

index 1f1761c6b4ae5db17abb44bc95c8689971044a01..84212c62f6e770cd0ef613cd5407c3dcd2b33af2 100644

--- a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc

+++ b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc

@@ -818,15 +818,13 @@ IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityInputDateTime) {

RunHtmlTest(FILE_PATH_LITERAL("input-datetime.html"));

}

+// Fails on OS X 10.9 and higher <https://crbug.com/430622>.

+#if !defined(OS_MACOSX)

IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,

AccessibilityInputDateTimeLocal) {

-#if defined(OS_MACOSX)

- // Fails on OS X 10.9 <https://crbug.com/430622>.

- if (base::mac::IsOSMavericks())

- return;

-#endif

RunHtmlTest(FILE_PATH_LITERAL("input-datetime-local.html"));

}

+#endif

IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityInputEmail) {

RunHtmlTest(FILE_PATH_LITERAL("input-email.html"));