chrome/browser/ui/views/ash/balloon_view_ash.cc - Issue 12780024: Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/ash/balloon_view_ash.cc

Issue 12780024: Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: caitp feedback Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/ash/balloon_view_ash.cc

diff --git a/chrome/browser/ui/views/ash/balloon_view_ash.cc b/chrome/browser/ui/views/ash/balloon_view_ash.cc

index acebcc9692d9442336a0c72ec19d243fc1533ab4..5e1f8c66e99a0f87379fa96096228a08afb72100 100644

--- a/chrome/browser/ui/views/ash/balloon_view_ash.cc

+++ b/chrome/browser/ui/views/ash/balloon_view_ash.cc

@@ -89,10 +89,10 @@ BalloonViewAsh::ImageDownload::ImageDownload(const Notification& notification,

return;

}

- contents->DownloadFavicon(url_,

- false,

- size_,

- base::Bind(&ImageDownload::Downloaded,AsWeakPtr()));

+ contents->DownloadImage(url_,

+ false,

+ size_,

+ base::Bind(&ImageDownload::Downloaded,AsWeakPtr()));

}