chrome/browser/ui/metro_pin_tab_helper_win.cc - Issue 12780024: Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/metro_pin_tab_helper_win.cc

Issue 12780024: Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: caitp feedback Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/metro_pin_tab_helper_win.cc

diff --git a/chrome/browser/ui/metro_pin_tab_helper_win.cc b/chrome/browser/ui/metro_pin_tab_helper_win.cc

index fc0e13c78068909228536be039f1ebaf81b0503b..13507c3bc837f944b72890982279d5e6463fd157 100644

--- a/chrome/browser/ui/metro_pin_tab_helper_win.cc

+++ b/chrome/browser/ui/metro_pin_tab_helper_win.cc

@@ -400,7 +400,7 @@ void MetroPinTabHelper::TogglePinnedToStartScreen() {

iter != favicon_url_candidates_.end();

++iter) {

favicon_chooser_->AddPendingRequest(

- web_contents()->DownloadFavicon(iter->icon_url,

+ web_contents()->DownloadImage(iter->icon_url,

true,

image_size,

base::Bind(&MetroPinTabHelper::DidDownloadFavicon,