chrome/browser/favicon/favicon_handler.h - Issue 12780024: Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_handler.h

Issue 12780024: Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: caitp feedback Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/favicon/favicon_handler.h

diff --git a/chrome/browser/favicon/favicon_handler.h b/chrome/browser/favicon/favicon_handler.h

index d734d9218fa73a22dff2c4c93bb655339be08217..23a92bbc9389185a08b545ca8bade88b4fd08418 100644

--- a/chrome/browser/favicon/favicon_handler.h

+++ b/chrome/browser/favicon/favicon_handler.h

@@ -100,9 +100,9 @@ class FaviconHandler {

// history / download service.

void ProcessCurrentUrl();

- // Message handler for IconHostMsg_DidDownloadFavicon. Called when the icon

+ // Message handler for ImageHostMsg_DidDownloadImage. Called when the image

// at |image_url| has been downloaded.

- // |bitmaps| is a list of all the frames of the icon at |image_url|.

+ // |bitmaps| is a list of all the frames of the image at |image_url|.

void OnDidDownloadFavicon(int id,

const GURL& image_url,

int requested_size,

« no previous file with comments | « android_webview/browser/icon_helper.cc ('k') | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »