android_webview/browser/icon_helper.cc - Issue 12780024: Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/icon_helper.cc

Issue 12780024: Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: caitp feedback Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/icon_helper.cc

diff --git a/android_webview/browser/icon_helper.cc b/android_webview/browser/icon_helper.cc

index 395733099e7aa980b23a4c4e1444a65b0cfcc3db..13091f280d8d0faeb623330c5ba8fb05d06ab888 100644

--- a/android_webview/browser/icon_helper.cc

+++ b/android_webview/browser/icon_helper.cc

@@ -59,7 +59,7 @@ void IconHelper::DidUpdateFaviconURL(int32 page_id,

// TODO(acleung): only fetch the URL if favicon downloading is enabled.

// (currently that is, the app has called WebIconDatabase.open()

// but we should decouple that setting via a boolean setting)

- web_contents()->DownloadFavicon(i->icon_url,

+ web_contents()->DownloadImage(i->icon_url,

true,

base::Bind(

« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_handler.h » ('j') | no next file with comments »