Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper

content/public/common/favicon_url.h

Index: content/public/common/favicon_url.h
diff --git a/content/public/common/favicon_url.h b/content/public/common/favicon_url.h
index b1d13cbfb8218afa941d0e58d5928066c855aeff..3b7c5bce06a4e06cd985e3f5adcd20883091e8f6 100644
--- a/content/public/common/favicon_url.h
+++ b/content/public/common/favicon_url.h
@@ -7,6 +7,7 @@
 
 #include "content/common/content_export.h"
 #include "googleurl/src/gurl.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebIconURL.h"
 
 namespace content {
 
@@ -24,6 +25,8 @@ struct CONTENT_EXPORT FaviconURL {
   FaviconURL(const GURL& url, IconType type);
   ~FaviconURL();
 
+  static IconType ToFaviconType(WebKit::WebIconURL::Type type);

[jam, 2013/03/21 01:14:51]

this is only called in render_view_impl.cc. so no need to put this method in the
public api. keep it as a static method in render_view_impl.cc

[Dmitry Titov, 2013/03/27 22:41:13]

Done.

+
   // The url of the icon.
   GURL icon_url;