content/common/view_messages.h - Issue 12780024: Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/view_messages.h

Issue 12780024: Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix build Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/view_messages.h

diff --git a/content/common/view_messages.h b/content/common/view_messages.h

index 0b2a13aecece3b3a5c3f481c482ef89050ea7001..98f72022052e074c0178e15756a4d5782517948f 100644

--- a/content/common/view_messages.h

+++ b/content/common/view_messages.h

@@ -19,6 +19,7 @@

#include "content/port/common/input_event_ack_state.h"

#include "content/public/common/common_param_traits.h"

#include "content/public/common/context_menu_params.h"

+#include "content/public/common/favicon_url.h"

#include "content/public/common/file_chooser_params.h"

#include "content/public/common/frame_navigate_params.h"

#include "content/public/common/javascript_message_type.h"

@@ -74,6 +75,7 @@ IPC_ENUM_TRAITS(WebKit::WebPopupType)

IPC_ENUM_TRAITS(WebKit::WebTextDirection)

IPC_ENUM_TRAITS(WebMenuItem::Type)

IPC_ENUM_TRAITS(WindowContainerType)

+IPC_ENUM_TRAITS(content::FaviconURL::IconType)

IPC_ENUM_TRAITS(content::FileChooserParams::Mode)

IPC_ENUM_TRAITS(content::InputEventAckState)

IPC_ENUM_TRAITS(content::JavaScriptMessageType)

@@ -198,6 +200,11 @@ IPC_STRUCT_TRAITS_BEGIN(content::EditCommand)

IPC_STRUCT_TRAITS_MEMBER(value)

IPC_STRUCT_TRAITS_END()

+IPC_STRUCT_TRAITS_BEGIN(content::FaviconURL)

+ IPC_STRUCT_TRAITS_MEMBER(icon_url)

+ IPC_STRUCT_TRAITS_MEMBER(icon_type)

+IPC_STRUCT_TRAITS_END()

IPC_STRUCT_TRAITS_BEGIN(content::FileChooserParams)

IPC_STRUCT_TRAITS_MEMBER(mode)

IPC_STRUCT_TRAITS_MEMBER(title)

@@ -2283,6 +2290,11 @@ IPC_MESSAGE_ROUTED1(ViewHostMsg_FrameDetached,

// first paint.

IPC_MESSAGE_ROUTED0(ViewHostMsg_WillInsertBody)

+// Notification that the urls for the favicon of a site has been determined.

+IPC_MESSAGE_ROUTED2(ViewHostMsg_UpdateFaviconURL,

+ int32 /* page_id */,

+ std::vector<content::FaviconURL> /* urls of the favicon */)

jam 2013/03/21 01:14:51 nit: convention is that the comment contains the p

Dmitry Titov 2013/03/27 22:41:13 Done.

#if defined(OS_ANDROID)

// Response to ViewMsg_FindMatchRects.

« no previous file with comments | « content/common/image_messages.h ('k') | content/content_common.gypi » ('j') | content/public/common/favicon_url.h » ('J')