Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8149)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/extensions/shell_window.cc

Issue 12780024: Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix build Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc ('k') | chrome/browser/ui/metro_pin_tab_helper_win.cc » ('j') | content/common/view_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/extensions/shell_window.cc
diff --git a/chrome/browser/ui/extensions/shell_window.cc b/chrome/browser/ui/extensions/shell_window.cc
index ade284ac01765dc9b3b300e66f1b4c9b9f007877..9cc334e36e81d38ebe5350a13c69d6eaadff66cf 100644
--- a/chrome/browser/ui/extensions/shell_window.cc
+++ b/chrome/browser/ui/extensions/shell_window.cc
@@ -358,9 +358,9 @@ string16 ShellWindow::GetTitle() const {
void ShellWindow::SetAppIconUrl(const GURL& url) {
app_icon_url_ = url;
- web_contents()->DownloadFavicon(url, kPreferredIconSize,
- base::Bind(&ShellWindow::DidDownloadFavicon,
- weak_ptr_factory_.GetWeakPtr()));
+ web_contents()->DownloadImage(url, kPreferredIconSize,
+ base::Bind(&ShellWindow::DidDownloadFavicon,
+ weak_ptr_factory_.GetWeakPtr()));
}
void ShellWindow::UpdateDraggableRegions(
« no previous file with comments | « chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc ('k') | chrome/browser/ui/metro_pin_tab_helper_win.cc » ('j') | content/common/view_messages.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698