Revert of Return Windows error code when create-process fails.

Revert of Return Windows error code when create-process fails. (patchset #12 id:220001 of https://codereview.chromium.org/1247993002/ )

Reason for revert:
Broke compilation on Win 64 GN. Info at http://crbug.com/517326.

Original issue's description:
> Return Windows error code when create-process fails.
>
> COULD_NOT_CREATE_PROCESS makes up about 10% of the setup errors; include the actual DWORD result code returned by ::CreateProcess by placing all result information into the proper location of the Registry for reading by Omaha.
>
> BUG=
>
> Committed: https://crrev.com/135f5f669574bd07eaedaf6b57503984aeb13be8
> Cr-Commit-Position: refs/heads/master@{#341938}

TBR=grt@chromium.org,ganesh@chromium.org,robertshield@chromium.org,bcwhite@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Committed: https://crrev.com/2ff13b4156388d057116f1da24d2144242514765
Cr-Commit-Position: refs/heads/master@{#342067}

[vabr (Chromium), 2015-08-06 06:12:55]

Created Revert of Return Windows error code when create-process fails.

[commit-bot: I haz the power, 2015-08-06 06:13:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1277833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1277833002/1

[commit-bot: I haz the power, 2015-08-06 06:13:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-06 06:14:15]

Patchset 1 (id:??) landed as
https://crrev.com/2ff13b4156388d057116f1da24d2144242514765
Cr-Commit-Position: refs/heads/master@{#342067}

[chromium-reviews, 2015-08-06 10:46:18]

Looks like the new file needs to be added to some other set of build
instructions.  Odd that none of the try-bots had this issue.
-- Brian


On Thu, Aug 6, 2015 at 2:12 AM, <vabr@chromium.org> wrote:

> Reviewers: grt (no reviews 7.31-8.19), S. Ganesh, robertshield, bcwhite,
>
> Message:
> Created Revert of Return Windows error code when create-process fails.
>
> Description:
> Revert of Return Windows error code when create-process fails. (patchset
> #12
> id:220001 of https://codereview.chromium.org/1247993002/ )
>
> Reason for revert:
> Broke compilation on Win 64 GN. Info at http://crbug.com/517326.
>
> Original issue's description:
>
>> Return Windows error code when create-process fails.
>>
>
> COULD_NOT_CREATE_PROCESS makes up about 10% of the setup errors; include
>> the
>>
> actual DWORD result code returned by ::CreateProcess by placing all result
> information into the proper location of the Registry for reading by Omaha.
>
> BUG=
>>
>
> Committed: https://crrev.com/135f5f669574bd07eaedaf6b57503984aeb13be8
>> Cr-Commit-Position: refs/heads/master@{#341938}
>>
>
> TBR=grt@chromium.org,ganesh@chromium.org,robertshield@chromium.org,
> bcwhite@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
>
> Please review this at https://codereview.chromium.org/1277833002/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+218, -423 lines):
>   M chrome/chrome_installer.gypi
>   M chrome/installer/mini_installer.gyp
>   M chrome/installer/mini_installer.gypi
>   M chrome/installer/mini_installer/configuration.h
>   M chrome/installer/mini_installer/configuration.cc
>   M chrome/installer/mini_installer/configuration_test.cc
>   M chrome/installer/mini_installer/mini_installer.cc
>   M chrome/installer/mini_installer/mini_installer_constants.h
>   M chrome/installer/mini_installer/mini_installer_constants.cc
>   D chrome/installer/mini_installer/regkey.h
>   D chrome/installer/mini_installer/regkey.cc
>
>
>


-- 
  Brian
  bcwhite@google.com
-----------------------------------------------------------------------------------------



*Treat someone as they are and they will remain that way.Treat someone as
they can be and they will become that way.*

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.