Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1277723003: Landing Recent QUIC changes until 8/4/2015 20:30 UTC. (Closed)

Created:
5 years, 4 months ago by ramant (doing other things)
Modified:
5 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC changes until 8/4/2015 20:30 UTC. Disable FLAGS_quic_require_handshake_confirmation for ZeroRTT test. relnote: Adding FLAGS_require_handshake_confirmation to emergency-disable QUIC 0-rtt Adding a reloadable flag to allow quickly disabling QUIC's 0-rtt handshake as an interim measure (0-rtt DoS protection) to allow StrikeServer turndown before full DoSServer integration. See b/20122788 Merge internal change: 99600488 https://codereview.chromium.org/1272153006/ relnote: Deprecate FLAGS_quic_send_fec_packet_only_on_fec_alarm. Merge internal change: 99599597 https://codereview.chromium.org/1279433004/ relnote: Limit the number of burst tokens in QUIC's pacing sender to the min of 10 and the current CWND in packets. Protected by FLAGS_quic_limit_pacing_burst. Should decrease retransmit rate for low CWND flows. Merge internal change: 99597412 https://codereview.chromium.org/1276983003/ Preparation for changing SpdyHeaderBlock to be ordered. This just reduces the number of files in upcoming CL by 2. No behavior change as these are currently entries into a map, and the key:value pairs haven't changed. However after changing to ordered SpdyHeaderBlock, the pseudo-header order of authority,path,scheme,method is what ends up getting written, and thus I'm changing the order here in advance. relnote: n/a (test only) Merge internal change: 99394725 https://codereview.chromium.org/1281463002/ relnote: Close QUIC connections due to too many open streams earlier in processing. No significant behavior change. Flag-protected by enabled FLAGS_exact_stream_id_delta. Replace the "maximum delta in stream ID" test on a newly-created stream with an exact test for the max number of open streams. Change the error in this case from QUIC_INVALID_STREAM_ID to QUIC_TOO_MANY_OPEN_STREAMS. FIXED=22477228 Merge internal change: 99369742 https://codereview.chromium.org/1277753002/ relnote: Minor format changes to keep the code similar to internal source. Merge internal change: 99250353 https://codereview.chromium.org/1274003002/ relnote: Change the QuicStreamSequencer to call OnDataAvailable instead of OnFinRead when the fin is consumed. Make ReliableQuicStream::OnFinRead() non-virtual and remove overrides in subclasses. Merge internal change: 99214926 https://codereview.chromium.org/1261273003/ R=rch@chromium.org Committed: https://crrev.com/44f4a2e23d2346bdb6e91602255a561d5484f2b5 Cr-Commit-Position: refs/heads/master@{#342349}

Patch Set 1 #

Patch Set 2 : Dont enable FLAGS_quic_require_handshake_confirmation to fix crypto tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -92 lines) Patch
M net/quic/congestion_control/pacing_sender.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/congestion_control/pacing_sender.cc View 2 chunks +14 lines, -2 lines 0 comments Download
M net/quic/congestion_control/pacing_sender_test.cc View 4 chunks +13 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_handshake.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_connection_test.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M net/quic/quic_flags.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_flags.cc View 1 2 chunks +14 lines, -3 lines 0 comments Download
M net/quic/quic_http_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 chunk +10 lines, -8 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_reliable_client_stream.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_reliable_client_stream.cc View 2 chunks +1 line, -10 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 4 chunks +16 lines, -4 lines 0 comments Download
M net/quic/quic_session.cc View 1 chunk +33 lines, -11 lines 0 comments Download
M net/quic/quic_session_test.cc View 3 chunks +43 lines, -5 lines 0 comments Download
M net/quic/quic_stream_sequencer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/reliable_quic_stream.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server_session.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream.h View 1 chunk +2 lines, -3 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M net/tools/quic/spdy_balsa_utils_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (8 generated)
ramant (doing other things)
5 years, 4 months ago (2015-08-06 23:02:47 UTC) #1
Ryan Hamilton
lgtm
5 years, 4 months ago (2015-08-06 23:10:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277723003/1
5 years, 4 months ago (2015-08-06 23:12:47 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/118617)
5 years, 4 months ago (2015-08-06 23:43:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277723003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277723003/20001
5 years, 4 months ago (2015-08-07 00:34:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/96246)
5 years, 4 months ago (2015-08-07 01:18:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277723003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277723003/20001
5 years, 4 months ago (2015-08-07 01:27:37 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/87822)
5 years, 4 months ago (2015-08-07 02:20:51 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277723003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277723003/20001
5 years, 4 months ago (2015-08-07 12:37:16 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-07 14:00:16 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 14:01:03 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/44f4a2e23d2346bdb6e91602255a561d5484f2b5
Cr-Commit-Position: refs/heads/master@{#342349}

Powered by Google App Engine
This is Rietveld 408576698