Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1277093006: Enable QUIC support in chromoting (Closed)

Created:
5 years, 4 months ago by Sergey Ulanov
Modified:
5 years, 4 months ago
Reviewers:
dcaiafa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@quic_adapters
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable QUIC support in chromoting - Added GetQuicChannelFactory() in JingleSession, so now it's possible to create channels over QUIC. - SessionConfig was updated to support QUIC-based transport. PseudoTCP is still used by default. - ContentDescription class is updated to exchange QuicConfig blobs generated by QuicChannelFactory. - ChromotingInstance allows to enable QUIC by enabling "quic" experiment in the webapp. BUG=448838 Committed: https://crrev.com/2a64040131d38a5455f62df534dedddbcff1cae1 Cr-Commit-Position: refs/heads/master@{#343463}

Patch Set 1 : #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -21 lines) Patch
M remoting/client/plugin/chromoting_instance.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/host/host_status_logger.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/pam_authorization_factory_posix.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M remoting/protocol/authenticator.h View 1 chunk +5 lines, -0 lines 0 comments Download
M remoting/protocol/channel_dispatcher_base.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/protocol/content_description.h View 4 chunks +8 lines, -2 lines 0 comments Download
M remoting/protocol/content_description.cc View 6 chunks +30 lines, -5 lines 0 comments Download
M remoting/protocol/content_description_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M remoting/protocol/fake_authenticator.h View 2 chunks +3 lines, -0 lines 0 comments Download
M remoting/protocol/fake_authenticator.cc View 1 2 4 chunks +31 lines, -2 lines 0 comments Download
M remoting/protocol/fake_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/fake_session.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/protocol/jingle_session.h View 1 2 3 chunks +4 lines, -1 line 0 comments Download
M remoting/protocol/jingle_session.cc View 1 2 8 chunks +39 lines, -4 lines 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 1 2 chunks +39 lines, -1 line 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M remoting/protocol/negotiating_authenticator_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/negotiating_authenticator_base.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M remoting/protocol/pairing_authenticator_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/pairing_authenticator_base.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/protocol/protocol_mock_objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/session.h View 2 chunks +1 line, -1 line 0 comments Download
M remoting/protocol/session_config.h View 3 chunks +10 lines, -0 lines 0 comments Download
M remoting/protocol/session_config.cc View 6 chunks +45 lines, -3 lines 0 comments Download
M remoting/protocol/third_party_authenticator_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/third_party_authenticator_base.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M remoting/protocol/v2_authenticator.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/v2_authenticator.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
Sergey Ulanov
5 years, 4 months ago (2015-08-10 20:27:11 UTC) #4
dcaiafa
lgtm https://codereview.chromium.org/1277093006/diff/60001/remoting/protocol/fake_authenticator.cc File remoting/protocol/fake_authenticator.cc (right): https://codereview.chromium.org/1277093006/diff/60001/remoting/protocol/fake_authenticator.cc#newcode176 remoting/protocol/fake_authenticator.cc:176: // Add authentication key in the last message ...
5 years, 4 months ago (2015-08-11 22:40:06 UTC) #5
Sergey Ulanov
https://codereview.chromium.org/1277093006/diff/60001/remoting/protocol/fake_authenticator.cc File remoting/protocol/fake_authenticator.cc (right): https://codereview.chromium.org/1277093006/diff/60001/remoting/protocol/fake_authenticator.cc#newcode176 remoting/protocol/fake_authenticator.cc:176: // Add authentication key in the last message send ...
5 years, 4 months ago (2015-08-14 18:44:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277093006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277093006/80001
5 years, 4 months ago (2015-08-14 18:45:09 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years, 4 months ago (2015-08-14 19:52:23 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 19:53:07 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2a64040131d38a5455f62df534dedddbcff1cae1
Cr-Commit-Position: refs/heads/master@{#343463}

Powered by Google App Engine
This is Rietveld 408576698