Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1273233002: Implement QuicChannel and QuicChannelFactory (Closed)

Created:
5 years, 4 months ago by Sergey Ulanov
Modified:
5 years, 4 months ago
Reviewers:
Ryan Hamilton, dcaiafa
CC:
chromium-reviews, cbentzel+watch_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement QuicChannel and QuicChannelFactory QuicChannelFactory implements StreamChannelFactory to create channels over a QUIC connection. The new code will be hooked up in a separate CL. BUG=448838 Committed: https://crrev.com/1c9834963f5c48eaf50d9676a61dec0ed1edae49 Cr-Commit-Position: refs/heads/master@{#343447}

Patch Set 1 #

Total comments: 15

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1331 lines, -23 lines) Patch
M net/quic/p2p/quic_p2p_session.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M net/quic/p2p/quic_p2p_session_test.cc View 1 2 6 chunks +33 lines, -11 lines 0 comments Download
M net/quic/p2p/quic_p2p_stream.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/base/compound_buffer.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M remoting/base/constants.h View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/base/constants.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/protocol/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/fake_datagram_socket.h View 2 chunks +15 lines, -0 lines 0 comments Download
M remoting/protocol/fake_datagram_socket.cc View 1 chunk +34 lines, -0 lines 0 comments Download
A remoting/protocol/quic_channel.h View 1 1 chunk +104 lines, -0 lines 0 comments Download
A remoting/protocol/quic_channel.cc View 1 2 3 1 chunk +179 lines, -0 lines 0 comments Download
A remoting/protocol/quic_channel_factory.h View 1 chunk +58 lines, -0 lines 0 comments Download
A remoting/protocol/quic_channel_factory.cc View 1 2 3 4 5 1 chunk +536 lines, -0 lines 0 comments Download
A remoting/protocol/quic_channel_factory_unittest.cc View 1 2 3 4 1 chunk +353 lines, -0 lines 0 comments Download
M remoting/remoting_srcs.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/remoting_test.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1277093006 Patch 80001

Messages

Total messages: 30 (14 generated)
Sergey Ulanov
Please let me know if you'd like me to give you overview of how everything ...
5 years, 4 months ago (2015-08-06 19:26:27 UTC) #2
dcaiafa
lgtm https://codereview.chromium.org/1273233002/diff/1/remoting/base/compound_buffer.h File remoting/base/compound_buffer.h (right): https://codereview.chromium.org/1273233002/diff/1/remoting/base/compound_buffer.h#newcode55 remoting/base/compound_buffer.h:55: // Copies |buffer_size| bytes to buffer and crops ...
5 years, 4 months ago (2015-08-10 23:31:36 UTC) #3
Sergey Ulanov
https://codereview.chromium.org/1273233002/diff/1/remoting/base/compound_buffer.h File remoting/base/compound_buffer.h (right): https://codereview.chromium.org/1273233002/diff/1/remoting/base/compound_buffer.h#newcode55 remoting/base/compound_buffer.h:55: // Copies |buffer_size| bytes to buffer and crops them. ...
5 years, 4 months ago (2015-08-11 21:34:00 UTC) #5
Sergey Ulanov
+rch@ Ryan, please approve changes in net/quic/p2p
5 years, 4 months ago (2015-08-11 21:34:32 UTC) #7
Ryan Hamilton
https://codereview.chromium.org/1273233002/diff/40001/net/quic/p2p/quic_p2p_session.cc File net/quic/p2p/quic_p2p_session.cc (right): https://codereview.chromium.org/1273233002/diff/40001/net/quic/p2p/quic_p2p_session.cc#newcode105 net/quic/p2p/quic_p2p_session.cc:105: } Looks like there are behavior changes in this ...
5 years, 4 months ago (2015-08-12 02:59:16 UTC) #8
Sergey Ulanov
https://codereview.chromium.org/1273233002/diff/40001/net/quic/p2p/quic_p2p_session.cc File net/quic/p2p/quic_p2p_session.cc (right): https://codereview.chromium.org/1273233002/diff/40001/net/quic/p2p/quic_p2p_session.cc#newcode105 net/quic/p2p/quic_p2p_session.cc:105: } On 2015/08/12 02:59:16, Ryan Hamilton wrote: > Looks ...
5 years, 4 months ago (2015-08-12 17:09:31 UTC) #9
Ryan Hamilton
lgtm net/ LGTM
5 years, 4 months ago (2015-08-13 17:05:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273233002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273233002/60001
5 years, 4 months ago (2015-08-13 19:13:25 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/39392)
5 years, 4 months ago (2015-08-13 20:41:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273233002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273233002/80001
5 years, 4 months ago (2015-08-13 21:16:42 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/39463)
5 years, 4 months ago (2015-08-13 22:51:00 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273233002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273233002/100001
5 years, 4 months ago (2015-08-14 00:20:50 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/39572)
5 years, 4 months ago (2015-08-14 02:05:00 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273233002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273233002/120001
5 years, 4 months ago (2015-08-14 17:25:46 UTC) #28
commit-bot: I haz the power
Committed patchset #6 (id:120001)
5 years, 4 months ago (2015-08-14 18:38:24 UTC) #29
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 18:39:04 UTC) #30
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/1c9834963f5c48eaf50d9676a61dec0ed1edae49
Cr-Commit-Position: refs/heads/master@{#343447}

Powered by Google App Engine
This is Rietveld 408576698