Editing sources for iOS //ui/base.

Editing sources for iOS //ui/base.


BUG=459705

[sherouk, 2015-08-06 17:32:33]

sherouk@google.com changed reviewers:
+ dpranke@chromium.org, sdefresne@chromium.org

[sherouk, 2015-08-06 17:34:03]

Can you review please?

[Dirk Pranke, 2015-08-06 17:40:12]

How are you testing your changes? Have you merged my CL in and are working on
top of that?

https://codereview.chromium.org/1276943002/diff/1/ui/base/BUILD.gn
File ui/base/BUILD.gn (right):

https://codereview.chromium.org/1276943002/diff/1/ui/base/BUILD.gn#newcode231
ui/base/BUILD.gn:231: sources = [
this needs to be at least "sources += ["

We should get a //ui/base owner to review this; it strikes me as odd that so
many of these files would not be needed on iOS, but I know nothing about this
code.

[sdefresne, 2015-08-07 12:26:59]

On 2015/08/06 at 17:40:12, dpranke wrote:
> How are you testing your changes? Have you merged my CL in and are working on
top of that?

We have a script that parses the output of "ninja -t graph" to get the list of
all sources files that are built. The script is run on the ninja files generated
by gyp and gn and the BUILD.gn files are updated so that both outputs are the
same. We were waiting for your CL to land before trying to build and check that
we can build those files.

From now on, we'll also ensure that all the newly added target build, including
for this CL.

> https://codereview.chromium.org/1276943002/diff/1/ui/base/BUILD.gn
> File ui/base/BUILD.gn (right):
> 
> https://codereview.chromium.org/1276943002/diff/1/ui/base/BUILD.gn#newcode231
> ui/base/BUILD.gn:231: sources = [
> this needs to be at least "sources += ["
> 
> We should get a //ui/base owner to review this; it strikes me as odd that so
many of these files would not be needed on iOS, but I know nothing about this
code.