Editing sources for iOS //ui/base.

ui/base/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ui.gni")
 import("//testing/test.gni")
 
 if (is_android) {
   import("//build/config/android/config.gni")
   import("//build/config/android/rules.gni")
 }
 
 build_ime = !is_ios
 
 component("base") {
   output_name = "ui_base"
   sources = [
-    "accelerators/accelerator.cc",
-    "accelerators/accelerator.h",
-    "accelerators/accelerator_history.cc",
-    "accelerators/accelerator_history.h",
-    "accelerators/accelerator_manager.cc",
-    "accelerators/accelerator_manager.h",
     "accelerators/menu_label_accelerator_util_linux.cc",
     "accelerators/menu_label_accelerator_util_linux.h",
     "accelerators/platform_accelerator.h",
     "accelerators/platform_accelerator_cocoa.h",
     "accelerators/platform_accelerator_cocoa.mm",
     "android/ui_base_jni_registrar.cc",
     "android/ui_base_jni_registrar.h",
-    "base_window.cc",
-    "base_window.h",
-    "clipboard/clipboard.cc",
-    "clipboard/clipboard.h",
     "clipboard/clipboard_android.cc",
     "clipboard/clipboard_android.h",
-    "clipboard/clipboard_constants.cc",
     "clipboard/clipboard_mac.h",
     "clipboard/clipboard_mac.mm",
     "clipboard/clipboard_types.h",
     "clipboard/clipboard_util_win.cc",
     "clipboard/clipboard_util_win.h",
     "clipboard/clipboard_win.cc",
     "clipboard/clipboard_win.h",
-    "clipboard/custom_data_helper.cc",
-    "clipboard/custom_data_helper.h",
     "clipboard/custom_data_helper_linux.cc",
     "clipboard/custom_data_helper_mac.mm",
-    "clipboard/scoped_clipboard_writer.cc",
-    "clipboard/scoped_clipboard_writer.h",
     "cocoa/animation_utils.h",
     "cocoa/appkit_utils.h",
     "cocoa/appkit_utils.mm",
     "cocoa/base_view.h",
     "cocoa/base_view.mm",
     "cocoa/cocoa_base_utils.h",
     "cocoa/cocoa_base_utils.mm",
     "cocoa/constrained_window/constrained_window_animation.h",
     "cocoa/constrained_window/constrained_window_animation.mm",
     "cocoa/controls/blue_label_button.h",
@@ skipping 39 matching lines @@
     "cocoa/underlay_opengl_hosting_window.h",
     "cocoa/underlay_opengl_hosting_window.mm",
     "cocoa/view_description.h",
     "cocoa/view_description.mm",
     "cocoa/window_size_constants.h",
     "cocoa/window_size_constants.mm",
     "cursor/cursor.cc",
     "cursor/cursor.h",
     "cursor/cursor_android.cc",
     "cursor/cursor_loader.h",
-    "cursor/cursor_util.cc",
-    "cursor/cursor_util.h",
     "cursor/cursor_win.cc",
-    "cursor/cursors_aura.cc",
-    "cursor/cursors_aura.h",
-    "cursor/image_cursors.cc",
-    "cursor/image_cursors.h",
-    "default_theme_provider.cc",
-    "default_theme_provider.h",
     "default_theme_provider_mac.mm",
     "device_form_factor.h",
     "device_form_factor_android.cc",
     "device_form_factor_android.h",
     "device_form_factor_desktop.cc",
     "device_form_factor_ios.mm",
-    "dragdrop/cocoa_dnd_util.h",
-    "dragdrop/cocoa_dnd_util.mm",
     "dragdrop/drag_drop_types.h",
     "dragdrop/drag_drop_types_win.cc",
     "dragdrop/drag_source_win.cc",
     "dragdrop/drag_source_win.h",
-    "dragdrop/drag_utils.cc",
-    "dragdrop/drag_utils.h",
     "dragdrop/drag_utils_aura.cc",
     "dragdrop/drag_utils_mac.mm",
     "dragdrop/drag_utils_win.cc",
     "dragdrop/drop_target_event.cc",
     "dragdrop/drop_target_event.h",
     "dragdrop/drop_target_win.cc",
     "dragdrop/drop_target_win.h",
-    "dragdrop/file_info.cc",
-    "dragdrop/file_info.h",
     "dragdrop/os_exchange_data.cc",
     "dragdrop/os_exchange_data.h",
     "dragdrop/os_exchange_data_provider_mac.h",
     "dragdrop/os_exchange_data_provider_mac.mm",
     "dragdrop/os_exchange_data_provider_win.cc",
     "dragdrop/os_exchange_data_provider_win.h",
     "hit_test.h",
     "idle/idle.cc",
     "idle/idle.h",
     "idle/idle_chromeos.cc",
@@ skipping 18 matching lines @@
     "l10n/l10n_util_plurals.cc",
     "l10n/l10n_util_plurals.h",
     "l10n/l10n_util_posix.cc",
     "l10n/l10n_util_win.cc",
     "l10n/l10n_util_win.h",
     "l10n/time_format.cc",
     "l10n/time_format.h",
     "layout.cc",
     "layout.h",
     "layout_mac.mm",
-    "models/button_menu_item_model.cc",
-    "models/button_menu_item_model.h",
-    "models/combobox_model.cc",
-    "models/combobox_model.h",
     "models/combobox_model_observer.h",
-    "models/dialog_model.cc",
-    "models/dialog_model.h",
     "models/list_model.h",
     "models/list_model_observer.h",
-    "models/list_selection_model.cc",
-    "models/list_selection_model.h",
-    "models/menu_model.cc",
-    "models/menu_model.h",
     "models/menu_model_delegate.h",
     "models/menu_separator_types.h",
-    "models/simple_combobox_model.cc",
-    "models/simple_combobox_model.h",
-    "models/simple_menu_model.cc",
-    "models/simple_menu_model.h",
-    "models/table_model.cc",
-    "models/table_model.h",
     "models/table_model_observer.h",
-    "models/tree_model.cc",
-    "models/tree_model.h",
     "models/tree_node_iterator.h",
     "models/tree_node_model.h",
     "nine_image_painter_factory.cc",
     "nine_image_painter_factory.h",
     "page_transition_types.cc",
     "page_transition_types.h",
     "resource/data_pack.cc",
     "resource/data_pack.h",
     "resource/material_design/material_design_controller.cc",
     "resource/material_design/material_design_controller.h",
     "resource/resource_bundle.cc",
     "resource/resource_bundle.h",
     "resource/resource_bundle_android.cc",
     "resource/resource_bundle_auralinux.cc",
     "resource/resource_bundle_ios.mm",
     "resource/resource_bundle_mac.mm",
     "resource/resource_bundle_win.cc",
     "resource/resource_bundle_win.h",
     "resource/resource_data_dll_win.cc",
     "resource/resource_data_dll_win.h",
     "resource/resource_handle.h",
     "template_expressions.cc",
     "template_expressions.h",
-    "text/bytes_formatting.cc",
-    "text/bytes_formatting.h",
-    "theme_provider.cc",
-    "theme_provider.h",
-    "touch/selection_bound.cc",
-    "touch/selection_bound.h",
     "touch/touch_device.h",
-    "touch/touch_editing_controller.cc",
-    "touch/touch_editing_controller.h",
-    "touch/touch_enabled.cc",
-    "touch/touch_enabled.h",
     "ui_base_export.h",
     "ui_base_exports.cc",
     "ui_base_paths.cc",
     "ui_base_paths.h",
     "ui_base_switches.cc",
     "ui_base_switches.h",
     "ui_base_switches_util.cc",
     "ui_base_switches_util.h",
     "ui_base_types.cc",
     "ui_base_types.h",
-    "user_activity/user_activity_detector.cc",
-    "user_activity/user_activity_detector.h",
-    "user_activity/user_activity_observer.h",
     "view_prop.cc",
     "view_prop.h",
     "webui/jstemplate_builder.cc",
     "webui/jstemplate_builder.h",
     "webui/web_ui_util.cc",
     "webui/web_ui_util.h",
     "win/accessibility_ids_win.h",
     "win/accessibility_misc_utils.cc",
     "win/accessibility_misc_utils.h",
     "win/atl_module.h",
@@ skipping 19 matching lines @@
     "win/shell.h",
     "win/touch_input.cc",
     "win/touch_input.h",
     "win/window_event_target.cc",
     "win/window_event_target.h",
     "window_open_disposition.cc",
     "window_open_disposition.h",
     "work_area_watcher_observer.h",
   ]
 
+  if (!is_ios) {
+    sources = [

[Dirk Pranke, 2015/08/06 17:40:12]

this needs to be at least "sources += ["

We should get a //ui/base owner to review this; it strikes me as odd that so
many of these files would not be needed on iOS, but I know nothing about this
code.

+      "accelerators/accelerator.cc",
+      "accelerators/accelerator.h",
+      "accelerators/accelerator_history.cc",
+      "accelerators/accelerator_history.h",
+      "accelerators/accelerator_manager.cc",
+      "accelerators/accelerator_manager.h",
+      "base_window.cc",
+      "base_window.h",
+      "clipboard/clipboard.cc",
+      "clipboard/clipboard.h",
+      "clipboard/clipboard_constants.cc",
+      "clipboard/custom_data_helper.cc",
+      "clipboard/custom_data_helper.h",
+      "clipboard/scoped_clipboard_writer.cc",
+      "clipboard/scoped_clipboard_writer.h",
+      "cursor/cursor_util.cc",
+      "cursor/cursor_util.h",
+      "cursor/cursors_aura.cc",
+      "cursor/cursors_aura.h",
+      "cursor/image_cursors.cc",
+      "cursor/image_cursors.h",
+      "default_theme_provider.cc",
+      "default_theme_provider.h",
+      "dragdrop/cocoa_dnd_util.h",
+      "dragdrop/cocoa_dnd_util.mm",
+      "dragdrop/drag_utils.cc",
+      "dragdrop/drag_utils.h",
+      "dragdrop/file_info.cc",
+      "dragdrop/file_info.h",
+      "models/button_menu_item_model.cc",
+      "models/button_menu_item_model.h",
+      "models/combobox_model.cc",
+      "models/combobox_model.h",
+      "models/dialog_model.cc",
+      "models/dialog_model.h",
+      "models/list_selection_model.cc",
+      "models/list_selection_model.h",
+      "models/menu_model.cc",
+      "models/menu_model.h",
+      "models/simple_combobox_model.cc",
+      "models/simple_combobox_model.h",
+      "models/simple_menu_model.cc",
+      "models/simple_menu_model.h",
+      "models/table_model.cc",
+      "models/table_model.h",
+      "models/tree_model.cc",
+      "models/tree_model.h",
+      "text/bytes_formatting.cc",
+      "text/bytes_formatting.h",
+      "theme_provider.cc",
+      "theme_provider.h",
+      "touch/selection_bound.cc",
+      "touch/selection_bound.h",
+      "touch/touch_editing_controller.cc",
+      "touch/touch_editing_controller.h",
+      "touch/touch_enabled.cc",
+      "touch/touch_enabled.h",
+      "user_activity/user_activity_detector.cc",
+      "user_activity/user_activity_detector.h",
+    ]
+  }
+
   if (is_win) {
     sources += [ "touch/touch_device_win.cc" ]
   } else if (is_android) {
     sources += [ "touch/touch_device_android.cc" ]
   } else if (is_ios) {
     sources += [ "touch/touch_device_ios.cc" ]
   } else if (is_linux) {
     sources += [ "touch/touch_device_linux.cc" ]
   } else {
     # Empty implementation for all other cases.
@@ skipping 19 matching lines @@
     "//base:i18n",
     "//net",
     "//third_party/icu",
     "//ui/events",
     "//ui/events/devices",
     "//ui/resources",
     "//ui/strings",
     "//url",
   ]
 
-  if (is_ios) {
-    sources += [
-      "l10n/l10n_util_mac.h",
-      "l10n/l10n_util_mac.mm",
-    ]
-  }
-
   if (toolkit_views) {
     deps += [ "//ui/events" ]
   }
 
   if (use_x11 && use_aura) {
     sources += [
       "x/selection_owner.cc",
       "x/selection_owner.h",
       "x/selection_requestor.cc",
       "x/selection_requestor.h",
@@ skipping 214 matching lines @@
       "device_form_factor_desktop.cc",
       "idle/idle.cc",
       "idle/idle.h",
     ]
   }
 }
 
 source_set("test_support") {
   testonly = true
   sources = [
+    "test/ios/keyboard_appearance_listener.h",
+    "test/ios/keyboard_appearance_listener.mm",
+    "test/ios/ui_view_test_utils.h",
+    "test/ios/ui_view_test_utils.mm",
     "test/material_design_controller_test_api.cc",
     "test/material_design_controller_test_api.h",
-    "test/nswindow_fullscreen_notification_waiter.h",
-    "test/nswindow_fullscreen_notification_waiter.mm",
     "test/scoped_fake_nswindow_fullscreen.h",
     "test/scoped_fake_nswindow_fullscreen.mm",
     "test/test_clipboard.cc",
     "test/test_clipboard.h",
     "test/ui_controls.h",
     "test/ui_controls_aura.cc",
     "test/ui_controls_internal_win.cc",
     "test/ui_controls_internal_win.h",
     "test/ui_controls_mac.mm",
     "test/ui_controls_win.cc",
-    "test/windowed_nsnotification_observer.h",
-    "test/windowed_nsnotification_observer.mm",
   ]
+  if (!is_ios) {
+    sources += [
+      "test/nswindow_fullscreen_notification_waiter.h",
+      "test/nswindow_fullscreen_notification_waiter.mm",
+      "test/windowed_nsnotification_observer.h",
+      "test/windowed_nsnotification_observer.mm",
+    ]
+  }
 
   public_deps = [
     ":base",
   ]
   deps = [
     "//base",
     "//skia",
     "//testing/gtest",
     "//ui/events:events_base",
     "//ui/gfx",
@@ skipping 50 matching lines @@
     "l10n/l10n_util_unittest.cc",
     "l10n/l10n_util_win_unittest.cc",
     "l10n/time_format_unittest.cc",
     "layout_unittest.cc",
     "models/tree_node_iterator_unittest.cc",
     "resource/data_pack_literal.cc",
     "resource/data_pack_unittest.cc",
     "resource/material_design/material_design_controller_unittest.cc",
     "resource/resource_bundle_unittest.cc",
     "template_expressions_unittest.cc",
+    "test/data/resource.h",
     "test/run_all_unittests.cc",
     "test/scoped_fake_nswindow_fullscreen_unittest.mm",
     "test/test_clipboard_unittest.cc",
     "user_activity/user_activity_detector_unittest.cc",
   ]
 
   data = []
   data_deps = []
 
   if (is_android) {
     sources -= [ "user_activity/user_activity_detector_unittest.cc" ]
   }
+  sources += [ "test/data/resource.h" ]
 
   if (is_ios) {
-    # Compile this Mac file on iOS as well.
+    # Compile these Mac files on iOS as well.
     set_sources_assignment_filter([])
-    sources += [ "l10n/l10n_util_mac_unittest.mm" ]
+    sources += [
+      "l10n/l10n_util_mac.h",
+      "l10n/l10n_util_mac.mm",
+      "l10n/l10n_util_mac_unittest.mm",
+    ]
     set_sources_assignment_filter(sources_assignment_filter)
   } else {  # !is_ios
     sources += [
       "accelerators/accelerator_manager_unittest.cc",
       "accelerators/menu_label_accelerator_util_linux_unittest.cc",
       "clipboard/custom_data_helper_unittest.cc",
       "cocoa/base_view_unittest.mm",
       "cocoa/cocoa_base_utils_unittest.mm",
       "cocoa/constrained_window/constrained_window_animation_unittest.mm",
       "cocoa/controls/blue_label_button_unittest.mm",
       "cocoa/controls/hover_image_menu_button_unittest.mm",
       "cocoa/controls/hyperlink_button_cell_unittest.mm",
       "cocoa/controls/hyperlink_text_view_unittest.mm",
       "cocoa/focus_tracker_unittest.mm",
       "cocoa/fullscreen_window_manager_unittest.mm",
       "cocoa/hover_image_button_unittest.mm",
       "cocoa/menu_controller_unittest.mm",
       "cocoa/nsgraphics_context_additions_unittest.mm",
       "cocoa/nsview_additions_unittest.mm",
       "cocoa/three_part_image_unittest.mm",
       "cocoa/tracking_area_unittest.mm",
       "models/list_model_unittest.cc",
       "models/list_selection_model_unittest.cc",
       "models/tree_node_model_unittest.cc",
-      "test/data/resource.h",
       "text/bytes_formatting_unittest.cc",
       "touch/selection_bound_unittest.cc",
       "webui/web_ui_util_unittest.cc",
     ]
   }
 
   if (build_ime) {
     sources += [
       "ime/candidate_window_unittest.cc",
       "ime/chromeos/character_composer_unittest.cc",
@@ skipping 144 matching lines @@
   }
   if (is_mac) {
     data += [ "$root_out_dir/ui_unittests Framework.framework/" ]
 
     if (is_asan && symbol_level == 0) {
       data += [ "$root_out_dir/ui_base_unittests.dSYM/" ]
     }
   }
 }
 # TODO(GYP) Mac (ui_base_tests_bundle)